summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2007-11-28Improve test coverage of CLOBBER_CACHE_ALWAYS by having it also forceTom Lane
reloading of operator class information on each use of LookupOpclassInfo. Had this been in place a year ago, it would have helped me find a bug in the then-new 'operator family' code. Now that we have a build farm member testing CLOBBER_CACHE_ALWAYS on a regular basis, it seems worth expending a little bit of effort here.
2007-11-28Adjust the names of a couple of tsearch index support functions that hadTom Lane
inappropriately generic-sounding names. This is more or less free since we already forced initdb for the next beta, and it may prevent confusion or name conflicts (particularly at the C-global-symbol level) down the road. Per my proposal yesterday.
2007-11-28Install a lookaside cache to speed up repeated lookups of the same operatorTom Lane
by short-circuiting schema search path and ambiguous-operator resolution computations. Remarkably, this buys as much as 45% speedup of repetitive simple queries that involve operators that are not an exact match to the input datatypes. It should be marginally faster even for exact-match cases, though I've not had success in proving an improvement in benchmark tests. Per report from Guillame Smet and subsequent discussion.
2007-11-28Proper capitalization of IspellPeter Eisentraut
2007-11-28Fix XML Schema structure for char types without length (bug #3782)Peter Eisentraut
2007-11-28Improve terminologyPeter Eisentraut
2007-11-28Fix typoPeter Eisentraut
2007-11-28Properly recognize and announce input errors.Peter Eisentraut
2007-11-28Change a stop word on the right-hand-side in the thesaurus file to be anBruce Momjian
ERROR, not NOTICE.
2007-11-27Fix plpgsql to not lookup block labels except in contexts where a block labelTom Lane
is sane (eg, EXIT argument or first part of a qualified identifier), and cause more-closely-nested record variables to take precedence over outer block labels. This cures the breakage exhibited by Marko Kreen that 8.3 no longer allowed a function's name to be used for a variable within the function, and makes plpgsql's handling of block labels more like Oracle's. It's important to fix this now because we are documenting the use of block labels as variable qualifiers for the first time in 8.3.
2007-11-27Fix pg_regress to check the directory it is actually reading files from,Tom Lane
not the image that (theoretically) should exist in the current directory. Jørgen Austvik
2007-11-27Add quote_literal(anyelement) to preserve (and, in fact, extend) aTom Lane
useful consequence of the former liberal implicit casting to text; namely that you can feed non-string values to quote_literal() and get unsurprising results. Per discussion.
2007-11-27Suppress compiler warning.Tom Lane
2007-11-27Make casts from xml to text independent of the XML option setting, thusPeter Eisentraut
immutable and indexable. Also fix the volatility settings of some other XML-related functions.
2007-11-27correct capitalizationPeter Eisentraut
2007-11-26Fix select_common_type() so that it can select a domain type, if all inputsTom Lane
to a UNION, CASE, or related construct are of the same domain type. The main part of this routine smashes domains to their base types, which seems necessary because the logic involves TypeCategory() and IsPreferredType(), neither of which work usefully on domains. However, we can add a first pass that just detects whether all the inputs are exactly the same type, and if so accept that without question (so long as it's not UNKNOWN). Per recent gripe from Dean Rasheed. In passing, remove some tests for InvalidOid, which have clearly been dead code for quite some time now, because getBaseType() would fail on that input. Also, clarify the manual's not-very-precise description of the existing algorithm's behavior.
2007-11-25Allow for X as well as x to be the prefix for hexadecimal character ref ↵Andrew Dunstan
entity numbers, as in HTML.
2007-11-25Fix XML tag namespace change inadvertantly missed from previous fix. AddAndrew Dunstan
regression test for XML names and numeric entities.
2007-11-25Use double quotes for quoting xml attributes.Peter Eisentraut
2007-11-25Fix thinko in comment.Tom Lane
2007-11-24Reduce routine successful-archiving message from LOG to DEBUG1 grade,Tom Lane
to reduce chattiness of logs. Per discussion. Simon Riggs
2007-11-24Fix (I think) broken usage of MultiByteToWideChar. I had missed theTom Lane
subtlety that this function only returns a null terminator if it's fed input that includes one; which, in the usage here, it's not. This probably fixes bugs reported by Thomas Haegi.
2007-11-24Slightly more paranoia and slightly better comments for use ofTom Lane
Windows-specific MultiByteToWideChar/WideCharToMultiByte calls.
2007-11-24Add missed entry for new money regression test.Tom Lane
2007-11-24Move resetting of currSchema to a spot where it's not vulnerable to gettingTom Lane
missed in possible future partial-drop scenarios. Improve comment. Per report from Zoltan Boszormenyi.
2007-11-24Add regression tests for MONEY type.D'Arcy J.M. Cain
2007-11-24Save another little bit of planner overhead on simple queries, by havingTom Lane
clauselist_selectivity skip some analysis that's useless when there's only one clause in the given list. Actually this can win even for not-so-simple queries, because we also apply clauselist_selectivity to sublists such as the quals matching an index; which are likely to have only a single entry even when the total query is quite complicated.
2007-11-24If pg_dump drops a schema, make sure 'search_path' it SET the next timeBruce Momjian
it is needed --- basically don't remember the previous 'search_path' after a drop schema because it might have failed but be created later.
2007-11-24Clarify how MONEY trims off trailing thousands separator.Bruce Momjian
2007-11-24Make the MONEY data type have a thousands separator != decimal symbol,Bruce Momjian
if the locale has the thousands separator as "". This now matches the to_char and psql numericlocale behavior. (Previously this data type was basically useless for such setups.)
2007-11-24Borland BCC does not support SSPI, per cnliou9@fastmail.fm.Bruce Momjian
2007-11-24Borland CC 5.5.1 needs ssize_t, per cnliou9@fastmail.fm.Bruce Momjian
2007-11-24Change fix_scan_expr() to avoid copying the input node tree in the common caseTom Lane
where rtoffset == 0. In that case there is no need to change Var nodes, and since filling in unset opfuncid fields is always safe, scribbling on the input tree to that extent is not objectionable. This brings the cost of this operation back down to what it was in 8.2 for simple queries. Per investigation of performance gripe from Guillaume Smet.
2007-11-23Avoid uselessly building a duplicate of the original clause in trivial casesTom Lane
where the EquivalenceClass machinery is unable to deduce anything more from a simple "var = const" qual clause. There are probably some more cases where this could be done, but this seems to take care of most of the added overhead for simple queries. Per gripe from Guillaume Smet. In passing, fix a problem that was exposed by this change: reconsider_outer_join_clause and friends were passing the wrong relids to build_implied_join_equality, resulting in RestrictInfos with the wrong required_relids. This mistake was masked in typical cases since the bogus RestrictInfos would never have escaped from the EquivalenceClass machinery, but I think there might be corner cases involving "broken" ECs where there would have been a visible failure even without the new optimization. In any case the code was certainly not operating as intended.
2007-11-23Fix white space in MONEY type code. Rename 'comma' to more genericBruce Momjian
'ssymbol' as used in previous function.
2007-11-23Fix buggy usage of vsnprintf in PL/Python by removing it altogether, insteadAlvaro Herrera
relying on stringinfo.c. This fixes a problem reported by Marko Kreen, but I didn't use his patch, per subsequent discussion.
2007-11-22Actually ... it's pretty silly that parse_oper.c doesn't set up theTom Lane
opfuncid of an OpExpr initially, considering that it has the information at hand already. We'll still treat opfuncid as a cache rather than a guaranteed-valid value, but this change saves one more syscache lookup in the normal code path.
2007-11-22Save one syscache lookup when examining volatility or strictness ofTom Lane
OpExpr and related nodes. We're going to have to set the opfuncid of such nodes eventually (if we haven't already), so we might as well exploit the opportunity to cache the function OID. Buys back some of the extra planner overhead noted by Guillaume Smet, though I still need to fool with equivclass.c to really respond to that.
2007-11-22Add more comments about thousands separator handling.Bruce Momjian
2007-11-22Prevent Perl from introducing a possibly-incompatible definition of typeTom Lane
"bool" into plperl.c. This has always been a hazard since Perl allows a platform-specific choice to define bool as int rather than char, but evidently this didn't happen on any platform we support ... until OS X 10.5. Per report from Brandon Maust. Back-patch as far as 8.0 --- a bit arbitrary, but it seems unlikely anyone will be trying to port 7.x onto new platforms.
2007-11-22Add comments about thousands separator logic.Bruce Momjian
2007-11-21WSATYPE_NOT_FOUND was already defined for BCC so don't redefine itBruce Momjian
(conflicting values).
2007-11-21Fix build of libpq for Borland CC.Bruce Momjian
2007-11-21When setting default thousands separator when locale has "", use logicBruce Momjian
so new thousands separator doesn't match decimal symbol.
2007-11-21Fix typo in comment.Bruce Momjian
2007-11-20Fix bogus length calculation that could lead to crash if the stringTom Lane
happened to be right up against the end of memory, per report from Matt Magoffin. While at it, avoid useless multiple copying of string by not depending on xmlStrncatNew.
2007-11-20Fix pg_ctl -t to register -t value, per Alvaro.Bruce Momjian
2007-11-20Change descriptions of entity and tag objects to "XML entity" and "XML tag".Andrew Dunstan
Allow tag and entity names that follow XML rules. Provide for hexadecimal as well as decimal numeric entities. Adjust code names to coincide with new descriptions.
2007-11-19Update comment.Bruce Momjian
2007-11-19Add comment about COMMENT ON DATABASE failing for differently-namedBruce Momjian
databases.