summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2007-05-14Report all dependent objects to the server log when a shared object is dropped,Alvaro Herrera
and only a truncated log of the objects in the current database to the client. Also, instead of reporting object counts for all databases on which the user might own objects, report only as many as fit in the predefined line count. This is to avoid flooding the client when the user owns too many objects, which could cause problems. Per report from Ed L. on April 4th and subsequent discussion.
2007-05-13Log directory we're installing into.Magnus Hagander
Per request from Andrew Dunstan.
2007-05-12Improve predicate_refuted_by_simple_clause() to handle IS NULL and IS NOT NULLTom Lane
more completely. The motivation for having it understand IS NULL at all was to allow use of "foo IS NULL" as one of the subsets of a partitioning on "foo", but as reported by Aleksander Kmetec, it wasn't really getting the job done. Backpatch to 8.2 since this is arguably a performance bug.
2007-05-12Fix the problem that creating a user-defined type named _foo, followed by oneTom Lane
named foo, would work but the other ordering would not. If a user-specified type or table name collides with an existing auto-generated array name, just rename the array type out of the way by prepending more underscores. This should not create any backward-compatibility issues, since the cases in which this will happen would have failed outright in prior releases. Also fix an oversight in the arrays-of-composites patch: ALTER TABLE RENAME renamed the table's rowtype but not its array type.
2007-05-11Fix my oversight in enabling domains-of-domains: ALTER DOMAIN ADD CONSTRAINTTom Lane
needs to check the new constraint against columns of derived domains too. Also, make it error out if the domain to be modified is used within any composite-type columns. Eventually we should support that case, but it seems a bit painful, and not suitable for a back-patch. For the moment just let the user know we can't do it. Backpatch to 8.2, which is the only released version that allows nested domains. Possibly the other part should be back-patched further.
2007-05-11Support arrays of composite types, including the rowtypes of regular tablesTom Lane
and views (but not system catalogs, nor sequences or toast tables). Get rid of the hardwired convention that a type's array type is named exactly "_type", instead using a new column pg_type.typarray to provide the linkage. (It still will be named "_type", though, except in odd corner cases such as maximum-length type names.) Along the way, make tracking of owner and schema dependencies for types more uniform: a type directly created by the user has these dependencies, while a table rowtype or auto-generated array type does not have them, but depends on its parent object instead. David Fetter, Andrew Dunstan, Tom Lane
2007-05-10Added some more error logging.Michael Meskes
2007-05-10- Synced parser and keyword listMichael Meskes
- Renamed update test so it hopefully runs on Vista
2007-05-08Reserve some pg_statistic "kind" codes for use by the ESRI ST_GeometryTom Lane
datatype project. Per request from Ale Raza (araza at esri.com).
2007-05-08Add a hash function for "numeric". Mark the equality operator forNeil Conway
numerics as "oprcanhash", and make the corresponding system catalog updates. As a result, hash indexes, hashed aggregation, and hash joins can now be used with the numeric type. Bump the catversion. The only tricky aspect to doing this is writing a correct hash function: it's possible for two Numerics to be equal according to their equality operator, but have different in-memory bit patterns. To cope with this, the hash function doesn't consider the Numeric's "scale" or "sign", and explictly skips any leading or trailing zeros in the Numeric's digit buffer (the current implementation should suppress any such zeros, but it seems unwise to rely upon this). See discussion on pgsql-patches for more details.
2007-05-08The appended patch addresses the outstanding issues of the recent guc patch.Peter Eisentraut
It makes PGCLIENTENCODING work again and uses bsearch() instead of iterating over the array of guc variables in guc_get_index(). Joachim Wieland
2007-05-07Make sure we don't skip databases that are supposed to be vacuumed "exactlyAlvaro Herrera
now". This can happen if the time granularity is not very high. Per ITAGAKI Takahiro.
2007-05-05Check return code from strxfrm on Windows since it has aMagnus Hagander
non-standard way of indicating errors, so we don't try to allocate INT_MAX bytes to store a result in.
2007-05-04Add a line to the EXPLAIN ANALYZE output for a Sort node, showing theTom Lane
actual sort strategy and amount of space used. By popular demand.
2007-05-04tas() support for Renesas' M32R processor. Kazuhiro InaokaTom Lane
2007-05-04Suppress a recently-introduced 'variable might be clobbered by longjmp' warning.Tom Lane
2007-05-04A few fixups in error handling: mark pg_re_throw() as noreturn for gcc,Tom Lane
and for other compilers, insert a dummy exit() call so that they understand PG_RE_THROW() doesn't return. Insert fflush(stderr) in ExceptionalCondition, per recent buildfarm evidence that that might not happen automatically on some platforms. And const-ify ExceptionalCondition's declaration while at it.
2007-05-04Teach tuplesort.c about "top N" sorting, in which only the first N tuplesTom Lane
need be returned. We keep a heap of the current best N tuples and sift-up new tuples into it as we scan the input. For M input tuples this means only about M*log(N) comparisons instead of M*log(M), not to mention a lot less workspace when N is small --- avoiding spill-to-disk for large M is actually the most attractive thing about it. Patch includes planner and executor support for invoking this facility in ORDER BY ... LIMIT queries. Greg Stark, with some editorialization by moi.
2007-05-03Tweak hash index AM to use the new ReadOrZeroBuffer bufmgr API when fetchingTom Lane
pages it intends to zero immediately. Just to show there is some use for that function besides WAL recovery :-). Along the way, fold _hash_checkpage and _hash_pageinit calls into _hash_getbuf and friends, instead of expecting callers to do that separately.
2007-05-03Release builds generate different strangely formatted export namesMagnus Hagander
for local symbols, that shouldn't be exported. This patch excludes them, cutting down about 10,000 exported symbols and decreasing the binary size by 20%.
2007-05-02Dept. of second thoughts: add comments cautioning against usingTom Lane
ReadOrZeroBuffer to fetch pages from beyond physical EOF. This would usually work, but would cause problems for md.c if writes occurred beyond a segment boundary when the previous segment file hadn't been fully extended.
2007-05-02During WAL recovery, when reading a page that we intend to overwrite completelyTom Lane
from the WAL data, don't bother to physically read it; just have bufmgr.c return a zeroed-out buffer instead. This speeds recovery significantly, and also avoids unnecessary failures when a page-to-be-overwritten has corrupt page headers on disk. This replaces a former kluge that accomplished the latter by pretending zero_damaged_pages was always ON during WAL recovery; which was OK when the kluge was put in, but is unsafe when restoring a WAL log that was written with full_page_writes off. Heikki Linnakangas
2007-05-02Fix things so that when CREATE INDEX CONCURRENTLY sets pg_index.indisvalidTom Lane
true at the very end of its processing, the update is broadcast via a shared-cache-inval message for the index; without this, existing backends that already have relcache entries for the index might never see it become valid. Also, force a relcache inval on the index's parent table at the same time, so that any cached plans for that table are re-planned; this ensures that the newly valid index will be used if appropriate. Aside from making C.I.C. behave more reasonably, this is necessary infrastructure for some aspects of the HOT patch. Pavan Deolasee, with a little further stuff from me.
2007-05-02Use the new TimestampDifferenceExceeds API instead of timestamp_cmp_internalAlvaro Herrera
and TimestampDifference, to make coding clearer. I think this should also fix the failure to start workers in platforms with low resolution timers, as reported by Itagaki Takahiro.
2007-05-02Fix failure to check for INVALID worker entry in the new autovacuum code, whichAlvaro Herrera
could happen when a worker took to long to start and was thus "aborted" by the launcher. Noticed by lionfish buildfarm member.
2007-05-02Fix oversight in PG_RE_THROW processing: it's entirely possible that thereTom Lane
isn't any place to throw the error to. If so, we should treat the error as FATAL, just as we would have if it'd been thrown outside the PG_TRY block to begin with. Although this is clearly a *potential* source of bugs, it is not clear at the moment whether it is an *actual* source of bugs; there may not presently be any PG_TRY blocks in code that can be reached with no outer longjmp catcher. So for the moment I'm going to be conservative and not back-patch this. The change breaks ABI for users of PG_RE_THROW and hence might create compatibility problems for loadable modules, so we should not put it into released branches without proof that it's needed.
2007-05-01Add wrapper script around install.pl that calls buildenv.bat before doingMagnus Hagander
the install. Dave Page
2007-05-01Fix a thinko in my patch of a couple months ago for bug #3116: it did theTom Lane
wrong thing when inlining polymorphic SQL functions, because it was using the function's declared return type where it should have used the actual result type of the current call. In 8.1 and 8.2 this causes obvious failures even if you don't have assertions turned on; in 8.0 and 7.4 it would only be a problem if the inlined expression were used as an input to a function that did run-time type determination on its inputs. Add a regression test, since this is evidently an under-tested area.
2007-04-30Change the timestamps recorded in transaction commit/abort xlog recordsTom Lane
from time_t to TimestampTz representation. This provides full gettimeofday() resolution of the timestamps, which might be useful when attempting to do point-in-time recovery --- previously it was not possible to specify the stop point with sub-second resolution. But mostly this is to get rid of TimestampTz-to-time_t conversion overhead during commit. Per my proposal of a day or two back.
2007-04-30Fix oversight in my patch of yesterday: forgot to ensure that stats wouldTom Lane
still be forced out at backend exit.
2007-04-30Implement rate-limiting logic on how often backends will attempt to sendTom Lane
messages to the stats collector. This avoids the problem that enabling stats_row_level for autovacuum has a significant overhead for short read-only transactions, as noted by Arjen van der Meijden. We can avoid an extra gettimeofday call by piggybacking on the one done for WAL-logging xact commit or abort (although that doesn't help read-only transactions, since they don't WAL-log anything). In my proposal for this, I noted that we could change the WAL log entries for commit/abort to record full TimestampTz precision, instead of only time_t as at present. That's not done in this patch, but will be committed separately.
2007-04-30Marginal performance hack: use a dedicated routine instead of copyObjectTom Lane
to copy nodes that are known to be Vars during plan reference adjustment. Saves useless memzero operation as well as the big switch in copyObject.
2007-04-30Marginal performance hack: avoid unnecessary work in expression_tree_mutator.Tom Lane
We can just palloc, instead of using makeNode, when we are going to overwrite the whole node anyway in the FLATCOPY macro. Also, use FLATCOPY instead of copyObject for common node types Var and Const.
2007-04-30Marginal performance hack: remove the loop that used to be needed toTom Lane
look through a freelist for a chunk of adequate size. For a long time now, all elements of a given freelist have been exactly the same allocated size, so we don't need a loop. Since the loop never iterated more than once, you'd think this wouldn't matter much, but it makes a noticeable savings in a simple test --- perhaps because the compiler isn't optimizing on a mistaken assumption that the loop would repeat. AllocSetAlloc is called often enough that saving even a couple of instructions is worthwhile.
2007-04-29Support for MOVE in PL/PgSQL. Initial patch from Magnus, some improvementsNeil Conway
by Pavel Stehule, and reviewed by Neil Conway.
2007-04-28Add support for IN as alternative to FROM in PL/PgSQL's FETCH statement,Neil Conway
for consistency with the backend's FETCH command. Patch from Pavel Stehule, reviewed by Neil Conway.
2007-04-27Modify processing of DECLARE CURSOR and EXPLAIN so that they can resolve theTom Lane
types of unspecified parameters when submitted via extended query protocol. This worked in 8.2 but I had broken it during plancache changes. DECLARE CURSOR is now treated almost exactly like a plain SELECT through parse analysis, rewrite, and planning; only just before sending to the executor do we divert it away to ProcessUtility. This requires a special-case check in a number of places, but practically all of them were already special-casing SELECT INTO, so it's not too ugly. (Maybe it would be a good idea to merge the two by treating IntoClause as a form of utility statement? Not going to worry about that now, though.) That approach doesn't work for EXPLAIN, however, so for that I punted and used a klugy solution of running parse analysis an extra time if under extended query protocol.
2007-04-27Properly set MODULE_PATHNAME based on module name instead of incorrectly basedMagnus Hagander
on directory name. Fixes the generation of .sql files in contrib/spi. Per complaint from Dave Page.
2007-04-27Removed non-existant function from extern.hMichael Meskes
2007-04-27Inlined two functions to get rid of va_list problems on some archs.Michael Meskes
2007-04-26Fix dynahash.c to suppress hash bucket splits while a hash_seq_search() scanTom Lane
is in progress on the same hashtable. This seems the least invasive way to fix the recently-recognized problem that a split could cause the scan to visit entries twice or (with much lower probability) miss them entirely. The only field-reported problem caused by this is the "failed to re-find shared lock object" PANIC in COMMIT PREPARED reported by Michel Dorochevsky, which was caused by multiply visited entries. However, it seems certain that mdsync() is vulnerable to missing required fsync's due to missed entries, and I am fearful that RelationCacheInitializePhase2() might be at risk as well. Because of that and the generalized hazard presented by this bug, back-patch all the supported branches. Along the way, fix pg_prepared_statement() and pg_cursor() to not assume that the hashtables they are examining will stay static between calls. This is risky regardless of the newly noted dynahash problem, because hash_seq_search() has never promised to cope with deletion of table entries other than the just-returned one. There may be no bug here because the only supported way to call these functions is via ExecMakeTableFunctionResult() which will cycle them to completion before doing anything very interesting, but it seems best to get rid of the assumption. This affects 8.2 and HEAD only, since those functions weren't there earlier.
2007-04-26Another tweak for tab completion of CREATE TEMP. Instead of onlyNeil Conway
completing CREATE { TEMP | TEMPORARY } TABLE, we should also suggest VIEW and SEQUENCE. Per Greg Sabino Mullane.
2007-04-26Minor enhancement to psql tab completion. If we see "CREATE TEMPORARY",Neil Conway
we can complete "TABLE". The previous coding only looked for "CREATE TEMP". Note that I didn't add TEMPORARY to the list of suggested completions after we've seen "CREATE", since TEMP is equivalent and more concise. But if the user has already manually typed TEMPORARY, we may as well complete TABLE for them.
2007-04-26Rename the newly-added commands for discarding session state.Neil Conway
RESET SESSION, RESET PLANS, and RESET TEMP are now DISCARD ALL, DISCARD PLANS, and DISCARD TEMP, respectively. This is to avoid confusion with the pre-existing RESET variants: the DISCARD commands are not actually similar to RESET. Patch from Marko Kreen, with some minor editorialization.
2007-04-26libpgtypes is a client lib, should not link with backend.Magnus Hagander
2007-04-26Generate "fake configure output" for pg_config, so that external buildsMagnus Hagander
like Slony can figure out which options were enabled in the build.
2007-04-25Install libpgport.lib as needed by some client programs.Magnus Hagander
Dave Page
2007-04-25Install headers in the same directory structure as Mingw.Magnus Hagander
Dave Page
2007-04-24Set maximum semaphore count to 32767 instead of 1. FixesMagnus Hagander
errorcode 298 when unlocking a semaphore more than once. Per report from Marcin Waldowski.
2007-04-23Don't try to install uuid-ossp since we don't build it.Magnus Hagander
Per buildfarm member mastodon.