summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2009-07-07Fix typo in comment.Tom Lane
2009-07-07More sensible character_octet_lengthPeter Eisentraut
For character types with typmod, character_octet_length columns in the information schema now show the maximum character length times the maximum length of a character in the server encoding, instead of some huge value as before.
2009-07-07Code review for patch to show definition of index columns in \d on index.Tom Lane
Safely schema-qualify the pg_get_indexdef call, make the query a bit prettier in -E mode, remove useless join to pg_index, make it more obvious that the header[] array is not overrun.
2009-07-06Use floor() not rint() when reducing precision of fractional seconds inTom Lane
timestamp_trunc, timestamptz_trunc, and interval_trunc(). This change only affects the float-datetime case; the integer-datetime case already behaved like truncation instead of rounding. Per gripe from Mario Splivalo. This is a pre-existing issue but I'm choosing not to backpatch, because it's such a corner case and there have not been prior complaints. The issue is largely moot anyway given the trend towards integer datetimes.
2009-07-06Fix ancient bug in handling of to_char modifier 'TH', when used with HH.Heikki Linnakangas
In what seems like an oversight, we used to treat 'TH' the same as lowercase 'th', but only with HH/HH12.
2009-07-06Fix set_append_rel_pathlist() to deal intelligently with cases whereTom Lane
substituting a child rel's output expressions into the appendrel's restriction clauses yields a pseudoconstant restriction. We might be able to skip scanning that child rel entirely (if we get constant FALSE), or generate a one-time filter. 8.3 more or less accidentally generated plans that weren't completely stupid in these cases, but that was only because an extra recursive level of subquery_planner() always occurred and allowed const-simplification to happen. 8.4's ability to pull up appendrel members with non-Var outputs exposes the fact that we need to work harder here. Per gripe from Sergey Burladyan.
2009-07-06Show definition of index columns in \d on indexPeter Eisentraut
This adds a column called "Definition" to the output of psql \d on an index, which shows the full expression behind the index column. For indexes on plain columns, this is redundant, but for expression indexes, this reveals the real expression. Author: Khee Chin <kheechin@gmail.com>
2009-07-06Per SQL spec (in particular, the grammar in SQL:2008 7.13) we should allowTom Lane
parentheses around the <query expression body> that follows a WITH clause, eg with cte(foo) as ( values(0) ) ((select foo from cte)); This seems to be just an oversight/thinko in gram.y. Noted while experimenting with bug #4902.
2009-07-06Fix handling of changed-Param signaling for CteScan plan nodes. We were usingTom Lane
the "cteParam" as a proxy for the possibility that the underlying CTE plan depends on outer-level variables or Params, but that doesn't work very well because it sometimes causes calling subqueries to be treated as SubPlans when they could be InitPlans. This is inefficient and also causes the outright failure exhibited in bug #4902. Instead, leave the cteParam out of it and copy the underlying CTE plan's extParams directly. Per bug #4902 from Marko Tiikkaja.
2009-07-03Add log_line_prefix placeholder %e to contain the current SQL statePeter Eisentraut
Author: Guillaume Smet <guillaume.smet@gmail.com>
2009-07-03Have \d show child tables that inherit from the specified parentPeter Eisentraut
As per discussion, \d shows only the number of child tables, because that could be hundreds, when used for partitioning. \d+ shows the actual list. Author: Damien Clochard <damien@dalibo.info>
2009-07-02Fix up pg_dump's --binary-upgrade option so that it behaves properly withTom Lane
inherited columns and check constraints. Per my recent trouble report.
2009-07-02Upgrade to Autoconf 2.63Peter Eisentraut
This upgrades the configure infrastructure to the latest Autoconf version. Some notable news are: - The workaround for the broken fseeko() test is gone. - Checking for unknown options is now provided by Autoconf itself. - Fixes for Mac OS X
2009-07-02Regression test for XML mapping functionalityPeter Eisentraut
I wrote this one while chasing down some bugs in the closing days of 8.4. It could be useful in the long run. This area of the code had no test coverage at all before.
2009-07-01Stamp HEAD as 8.5devel.Tom Lane
2009-06-30Add missed src/include/foreign subdirectory to the set installed intoTom Lane
INSTALLDIR/include/server/. Itagaki Takahiro
2009-06-27Bundle v8.4.0Marc G. Fournier
2009-06-26Cleanup and code review for the patch that made bgwriter active duringTom Lane
archive recovery. Invent a separate state variable and inquiry function for XLogInsertAllowed() to clarify some tests and make the management of writing the end-of-recovery checkpoint less klugy. Fix several places that were incorrectly testing InRecovery when they should be looking at RecoveryInProgress or XLogInsertAllowed (because they will now be executed in the bgwriter not startup process). Clarify handling of bad LSNs passed to XLogFlush during recovery. Use a spinlock for setting/testing SharedRecoveryInProgress. Improve quite a lot of comments. Heikki and Tom
2009-06-26Translation updates for 8.4 release.Peter Eisentraut
File that are translated less than 80% have been removed, as per new translation team policy.
2009-06-25Add __attribute__((format_arg(1))) to the declaration of err_gettext(),Tom Lane
to restore gcc's ability to crosscheck format arguments within elog.c. Noted in a test compilation with -Wformat-nonliteral enabled.
2009-06-25Fix some serious bugs in archive recovery, now that bgwriter is activeHeikki Linnakangas
during it: When bgwriter is active, the startup process can't perform mdsync() correctly because it won't see the fsync requests accumulated in bgwriter's private pendingOpsTable. Therefore make bgwriter responsible for the end-of-recovery checkpoint as well, when it's active. When bgwriter is active (= archive recovery), the startup process must not accumulate fsync requests to its own pendingOpsTable, since bgwriter won't see them there when it performs restartpoints. Make startup process drop its pendingOpsTable when bgwriter is launched to avoid that. Update minimum recovery point one last time when leaving archive recovery. It won't be updated by the end-of-recovery checkpoint because XLogFlush() sees us as out of recovery already. This fixes bug #4879 reported by Fujii Masao.
2009-06-25The code to unlink dropped relations in FinishPreparedTransaction() wasHeikki Linnakangas
acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted this from a redo-function in the relation forks patch. Noticed by Tom Lane while he was looking through callers of smgrdounlink().
2009-06-25Disallow empty passwords in LDAP authentication, the same wayMagnus Hagander
we already do it for PAM.
2009-06-24Correct grammar in picksplit debug messagesPeter Eisentraut
2009-06-24parse_ident_usermap() shuold use ereport(LOG) and not ERROR, and put theMagnus Hagander
return value in the *error_p variable. Noted by Tom.
2009-06-23Properly initialize SSL engines when used from libpq. This is required forMagnus Hagander
most external engines. Per report and initial code from Lars Kanis
2009-06-23Fix an ancient error in dist_ps (distance from point to line segment), whichTom Lane
a number of other geometric operators also depend on. It miscalculated the slope of the perpendicular to the given line segment anytime that slope was other than 0, infinite, or +/-1. In some cases the error would be masked because the true closest point on the line segment was one of its endpoints rather than the intersection point, but in other cases it could give an arbitrarily bad answer. Per bug #4872 from Nick Roosevelt. Bug goes clear back to Berkeley days, so patch all supported branches. Make a couple of cosmetic adjustments while at it.
2009-06-23Fix the makefiles to fail cleanly if Perl is needed but not present. ThisTom Lane
used to work as intended, but got broken some time ago (a quoted empty string is not an empty string), and got broken some more by the changes to generate ecpg's preproc.y automatically. Given all the unprotected uses of $(PERL) elsewhere, it seems best to make use of the $(missing) script rather than trying to ensure each such use is protected individually. Also fix various bits of documentation that omitted to mention Perl as a requirement for building from a CVS pull. Per a complaint from Robert Haas.
2009-06-22bundle RC2REL8_4_RC2Marc G. Fournier
2009-06-22For bulk write operations (eg COPY IN), use a ring buffer of 16MB insteadTom Lane
of the 256KB limit originally enforced by a patch committed 2008-11-06. Per recent test results, the smaller size resulted in an undesirable decrease in bulk data loading speed, due to COPY processing frequently getting blocked for WAL flushing. This area might need more tweaking later, but this setting seems to be good enough for 8.4.
2009-06-22Make to_timestamp and friends skip leading spaces before an integer field,Tom Lane
even when not in FM mode. This improves compatibility with Oracle and with our pre-8.4 behavior, as per bug #4862. Brendan Jurd Add a couple of regression test cases for this. In passing, get rid of the labeling of the individual test cases; doesn't seem to be good for anything except causing extra work when inserting a test... Tom Lane
2009-06-22Revert dubious message wording change.Tom Lane
2009-06-21Message fixesPeter Eisentraut
2009-06-20Fix things so that array_agg_finalfn does not modify or free its inputTom Lane
ArrayBuildState, per trouble report from Merlin Moncure. By adopting this fix, we are essentially deciding that aggregate final-functions should not modify their inputs ever. Adjust documentation and comments to match that conclusion.
2009-06-18Refine the use of terminology around bound and unbound cursors and cursorPeter Eisentraut
variables. Remove the confusing term "reference cursor".
2009-06-18Fix a few errors in comments. Patch by Fujii Masao, plus the one inHeikki Linnakangas
visibilitymap.c by me.
2009-06-18Fix the just-reported problem that you can't specify all four trigger eventTom Lane
types in CREATE TRIGGER. While at it, clean up the amazingly tedious and inextensible way that the trigger event type list was handled. Per report from Greg Sabino Mullane.
2009-06-17ExecAgg() failed to finish running out set-returning functions in the lastTom Lane
aggregated tuple of a run. Per report from Laurenz Albe. This is a new bug in 8.4, but only because prior versions rejected SRFs in an Agg plan node altogether.
2009-06-17Fix typo in error message: tgargv -> tg_argvPeter Eisentraut
2009-06-14Change test tables in copy2 regression test to be temporary tables.Tom Lane
This prevents autovacuum from reclaiming free space in them and causing the test's output row order to change, which is causing intermittent bogus failure reports in the buildfarm. Backpatch to 8.3. The issue exists further back, but since autovacuum was not on by default before 8.3, it's not a problem for buildfarm testing.
2009-06-13Fix get_sort_group_operators() so that it doesn't think arrays can be groupedTom Lane
via hashing. Eventually we ought to make that possible, but it won't happen for 8.4. Per yesterday's report from Robert Haas.
2009-06-13Tweak the display of incoming foreign-key constraints in \d, per discussionPeter Eisentraut
on hackers. Also, take that string out of the translation roster, since it's now entirely pseudo-SQL.
2009-06-12Fix several places where a function was declared static and then definedTom Lane
without static. Per testing with a compiler that complains about this.
2009-06-12time to tag rc1 ...REL8_4_RC1Marc G. Fournier
2009-06-12Tighten typedef check for Linux.Bruce Momjian
2009-06-12Mention BSD/OS find_typedef behavior.Bruce Momjian
2009-06-11Document struct/union problem with pgindent.Bruce Momjian
2009-06-11Revisit AlterTableCreateToastTable's API once again, hoping to make it whatTom Lane
pg_migrator actually needs and not just a partial solution. We have to be able to specify the OID that the new toast table should be created with.
2009-06-11Remove our inadequate kluge that tried to get AIX's various broken versionsTom Lane
of getaddrinfo() to work. Instead, recommend updating the OS to get a working version of getaddrinfo. Per recent discussions.
2009-06-11Update time zone data files to tzdata release 2009i: DST law changes inTom Lane
Bangladesh, Egypt, Jordan, Pakistan.