summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2010-03-18Prevent the injection of invalidly encoded strings by PL/Python into PostgreSQLPeter Eisentraut
with a few strategically placed pg_verifymbstr calls.
2010-03-18Message style tuningPeter Eisentraut
2010-03-18Mention way to get commit details for release notes.Bruce Momjian
2010-03-18Use data-type specific conversion functions also in plpy.executePeter Eisentraut
In PLy_spi_execute_plan, use the data-type specific Python-to-PostgreSQL conversion function instead of passing everything through InputFunctionCall as a string. The equivalent fix was already done months ago for function parameters and return values, but this other gateway between Python and PostgreSQL was apparently forgotten. As a result, data types that need special treatment, such as bytea, would misbehave when used with plpy.execute.
2010-03-18Add restartpoint_command option to recovery.conf. Fix bug in %r handlingHeikki Linnakangas
in recovery_end_command, it always came out as 0 because InRedo was cleared before recovery_end_command was executed. Also, always take ControlFileLock when reading checkpoint location for %r. The recovery_end_command bug and the missing locking was present in 8.4 as well, that part of this patch will be backported separately.
2010-03-18Add vacuum_defer_cleanup_age to postgresql.conf.sample.Simon Riggs
2010-03-17Message style tuningPeter Eisentraut
2010-03-17Fix peculiar, untranslatable message concatenation attemptPeter Eisentraut
2010-03-17Pass incompletely-transformed aggregate argument lists as separate parametersTom Lane
to transformAggregateCall, instead of abusing fields in Aggref to carry them temporarily. No change in functionality but hopefully the code is a bit clearer now. Per gripe from Gokulakannan Somasundaram.
2010-03-16Throw a nicer error message if a standby server attempts to connect whileHeikki Linnakangas
the master is still in recovery. We don't support cascading slaves yet. Patch by Fujii Masao, with slightly changed wording.
2010-03-15Remove incorrect comment from GetWriteRecPtr(): the return value is alwaysSimon Riggs
correct, as described in comments at start of xlog.c
2010-03-14Update oidjoins regression test for 9.0.Tom Lane
2010-03-13Revert all keepalive moves, reevaluate.Bruce Momjian
2010-03-13Move more tcp keepalive macros to be consistent.Bruce Momjian
2010-03-13Move TCP keepalive macro definitionBruce Momjian
Jaime Casanova
2010-03-13Add libpq warning message if the .pgpass-retrieved password fails.Bruce Momjian
Add ERRCODE_INVALID_PASSWORD sqlstate error code.
2010-03-13Allow underscores in tsearch email addressses, per RFC 5322 and reportBruce Momjian
by Dan O'Hara. Patch by Teodor Sigaev
2010-03-13Small adjustment by pgindent.Bruce Momjian
2010-03-12Add some logging code for unexpected cases in pgstat.c, particularly beingTom Lane
unable to read a stats file for reasons other than ENOENT, and having to reset last_statrequest because it's later than current time in the collector. Not clear if this will shed any light on the "pgstat wait timeout" business, but it seems like a good idea in general. In passing, do some message-style-police work on recently-added pgstat_reset_shared_counters code.
2010-03-12Fix a commented-out block of code that pgindent didn't understandTom Lane
properly; it's been making that comment uglier with each run.
2010-03-11Add missing reset of need_initialization in reloptions code.Tom Lane
This resulted in useless extra work during every call of parseRelOptions, but no bad effects other than that. Noted by Alvaro.
2010-03-11Modify psql's \d printout to fold exclusion constraints in with regularTom Lane
indexes, rather than printing them twice. Per my gripe when the exclusion constraint feature was committed.
2010-03-11Sync timezone code with tzcode 2010c from the Olson group. This fixes someTom Lane
corner cases that come up in certain timezones (apparently, only those with lots and lots of distinct TZ transition rules, as far as I can gather from a quick scan of their archives). Per suggestion from Jeevan Chalke. Back-patch to 8.4. Possibly we need to push this into earlier releases as well, but I'm hesitant to update them to the 64-bit tzcode without more thought and testing.
2010-03-11Fix bug in KnownAssignedXidsMany(). I saw this when looking at theHeikki Linnakangas
assertion failure reported by Erik Rijkers, but this alone doesn't explain the failure.
2010-03-11Fix comment which was apparently copy-pasted from another function.Heikki Linnakangas
2010-03-11Simplify a couple of pg_dump and psql \d queries about index constraintsTom Lane
by joining to pg_constraint.conindid, instead of the former technique of joining indirectly through pg_depend. This is much more straightforward and probably faster as well. I had originally desisted from changing these queries when conindid was added because I was worried about losing performance, but if we join on conrelid as well as conindid then the index on conrelid can be used when pg_constraint is large.
2010-03-11Update comment for pg_constraint.conindid to mention that it's used forTom Lane
exclusion constraints. Not sure how we managed to update the comment for it in catalogs.sgml but miss this one.
2010-03-10Fix incorrect comment about permissions checking being done in utility.c.Robert Haas
Noted while reviewing a patch from KaiGai Kohei.
2010-03-10pg_start_backup() can use a share lock to lock ControlFileLockItagaki Takahiro
instead of an exclusive lock. The change is almost for code cleanup. Since there seems to be no performance benefits from it, backports should not be needed. Fujii Masao
2010-03-09Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV in plperl.Tom Lane
The latter is considered unwarranted chumminess with the implementation, and can lead to crashes with recent Perl versions. Report and fix by Tim Bunce. Back-patch to all versions containing the questionable coding pattern.
2010-03-09Update time zone data files to tzdata release 2010d: DST law changes in Fiji,Alvaro Herrera
Samoa, Chile; corrections to recent changes in Paraguay and Bangladesh.
2010-03-09ecpg now adds a unique counter to its varchar struct definitions to make ↵Michael Meskes
these definitions unique, too. It used to use the linenumber but in the rare case of two definitions in one line this was not unique.
2010-03-09Add checks for valid encoding of query strings passed to SPI by plperl.Andrew Dunstan
2010-03-08Return proper exit code (3) from psql when ON_ERROR_STOP=on andBruce Momjian
--single-transaction are both used and the failure happens in commit, e.g. failed deferred trigger. Also properly free BEGIN/COMMIT result structures from --single-transaction. Per report from Dominic Bevacqua
2010-03-08Better test the content of the SQLSTATE string in ecpglib than the pointer.Michael Meskes
2010-03-08Require hostname to be set when using GSSAPI authentication. Without it,Magnus Hagander
the GSSAPI libraries crash. Noted by Zdenek Kotala
2010-03-08Disallow gssapi authentication on local connections, since itMagnus Hagander
requires a hostname to function. Noted by Zdenek Kotala
2010-03-08Update time zone data files to tzdata release 2010c: DST law changes inTom Lane
Bangladesh, Mexico, Paraguay.
2010-03-07Revert patch for --psqlrc=FILENAME in psql.Magnus Hagander
2010-03-06Fix warning messages in restrict_and_check_grant() to include the column nameTom Lane
when warning about column-level privileges. This is more useful than before and makes the apparent duplication complained of by Piyush Newe not so duplicate. Also fix lack of quote marks in a related message text. Back-patch to 8.4, where column-level privileges were introduced. Stephen Frost
2010-03-06Add --psqlrc=FILENAME parameter to psql, to process an explicitly namedMagnus Hagander
file instead of ~/.psqlrc on startup.
2010-03-06When reading pg_hba.conf and similar files, do not treat @file as an inclusionTom Lane
unless (1) the @ isn't quoted and (2) the filename isn't empty. This guards against unexpectedly treating usernames or other strings in "flat files" as inclusion requests, as seen in a recent trouble report from Ed L. The empty-filename case would be guaranteed to misbehave anyway, because our subsequent path-munging behavior results in trying to read the directory containing the current input file. I think this might finally explain the report at http://archives.postgresql.org/pgsql-bugs/2004-05/msg00132.php of a crash after printing "authentication file token too long, skipping", since I was able to duplicate that message (though not a crash) on a platform where stdio doesn't refuse to read directories. We never got far in investigating that problem, but now I'm suspicious that the trigger condition was an @ in the flat password file. Back-patch to all active branches since the problem can be demonstrated in all branches except HEAD. The test case, creating a user named "@", doesn't cause a problem in HEAD since we got rid of the flat password file. Nonetheless it seems like a good idea to not consider quoted @ as a file inclusion spec, so I changed HEAD too.
2010-03-05In case the connection magically disappears libecpg only returns an internalMichael Meskes
error sqlstate. This change makes it return a correct value..
2010-03-04Fix IsBinaryCoercible to not confuse a cast using in/out functionsHeikki Linnakangas
with binary compatibility. Backpatch to 8.4 where INOUT casts were introduced.
2010-03-03Add C comment about DDL changes possibly causing pg_dump errors.Bruce Momjian
2010-03-03Document that "Q" is ignored by to_date and to_timestamp. Add C commentBruce Momjian
about the behavior. Document that quotes in to_date, to_timestamp, to_number skip input characters.
2010-03-03Fix a couple of places that would loop forever if attempts to read a stdio fileTom Lane
set ferror() but never set feof(). This is known to be the case for recent glibc when trying to read a directory as a file, and might be true for other platforms/cases too. Per report from Ed L. (There is more that we ought to do about his report, but this is one easily identifiable issue.)
2010-03-03Fix pg_dump of ACLs of foreign servers. The command to grant/revokeHeikki Linnakangas
privileges of foreign servers is "GRANT ... ON *FOREIGN* SERVER ...".
2010-03-03Export xml.c's libxml-error-handling support so that contrib/xml2 can use itTom Lane
too, instead of duplicating the functionality (badly). I renamed xml_init to pg_xml_init, because the former seemed just a bit too generic to be safe as a global symbol. I considered likewise renaming xml_ereport to pg_xml_ereport, but felt that the reference to ereport probably made it sufficiently PG-centric already.
2010-03-03Make iconv work like other optional libraries for MSVC.Andrew Dunstan