| Age | Commit message (Collapse) | Author |
|---|
|
a warning when a variable is used as a format string for printf()
and similar functions (if the variable is derived from untrusted
data, it could include unexpected formatting sequences). This
emits too many warnings to be enabled by default, but it does
flag a few dubious constructs in the Postgres tree. This patch
fixes up the obvious variants: functions that are passed a variable
format string but no additional arguments.
Most of these are harmless (e.g. the ruleutils stuff), but there
is at least one actual bug here: if you create a trigger named
"%sfoo", pg_dump will read uninitialized memory and fail to dump
the trigger correctly.
|
|
incorrect -F argument: write_msg() expects its first parameter to be a
"module name", not the format string.
|
|
of timetz values misbehaved in --enable-integer-datetime cases, and
EXTRACT(EPOCH) subtracted the zone instead of adding it in all cases.
Backpatch to all supported releases (except --enable-integer-datetime code
does not exist in 7.2).
|
|
|
|
isBeforeFirst and isAfterLast both return false for an empty result
so the checking to make sure the user is on a valid row wasn't
working.
Also don't allow an insert without specifying at least one column
value because INSERT INTO tab() values() is a syntax error.
|
|
end of the ResultSet we can't try to load that row because it
doesn't exist and will throw an Exception.
Reported by Prasanth.
|
|
it. Per report from Marinos Yannikos.
|
|
--enable-integer-datetimes case. Per report from Oliver Siegmar.
|
|
results in an exception being thrown when it really should be a
no-op.
|
|
isn't presently set up to pass them an expected tuple descriptor. Bug has
been there since 7.3 but was just recently reported by Thomas Hallgren.
|
|
that is a plain NULL and not a COALESCE with no inputs. Fixes crash
reported by Michael Williamson.
|
|
outer side of an outer join. Per andrew@supernews.
|
|
exit. Without this, operations triggered during backend exit (such as
temp table deletions) won't be counted ... which given heavy usage of
temp tables can lead to pg_autovacuum falling way behind on the need
to vacuum pg_class and pg_attribute. Per reports from Steve Crawford
and others.
|
|
when a zero-month interval is given. Per discussion with Karel.
|
|
its private storage, because that belongs to the function that it is
supposed to call. Per report from Ezequiel Tolnay.
|
|
who for some reason isn't marked usecreatedb. Per report from Alexander
Pravking. Also fix sloppy coding in have_createdb_privilege().
|
|
no held locks. This maintains the invariant that proclocks are present
only for procs that are holding or awaiting a lock; when this is not
true, LockRelease will fail. Per report from Stephen Clouse.
|
|
into the sub-SELECT targetlist when it appears in the context
INSERT INTO foo SELECT $1 ... Per report from Abhijit Menon-Sen.
|
|
|
|
for all SPI-created cursors.
|
|
overrunning the array, not after.
|
|
minimally-invasive fix for stable branches; a cleaner fix will be
committed to HEAD soon.
|
|
there are corner cases involving dropping toasted columns in which the
previous coding would fail, too: the new version of the table might not
have any TOAST table, but we'd still propagate possibly-wide values of
dropped columns forward.
|
|
CLUSTER failure after ALTER TABLE SET WITHOUT OIDS.
|
|
|
|
functions of the aggregate, at both aggregate creation and execution times.
|
|
to fix failure to cope with quote marks in field values; not to mention
that it is shorter and faster. Per report from Charles Haron.
|
|
|
|
|
|
left input's sorting, because null rows may be inserted at various points.
Per report from Ferenc Lutischá¸n.
|
|
to a refcursor declaration are specified. This is a minimally-invasive fix
for the buffer overrun -- a more thorough cleanup will be checked into
HEAD.
|
|
Report from Oliver Siegmar.
|
|
GERMAN datestyles. Ancient bug reported by Terry Lee Tucker.
|
|
index predicate uses temporary memory for evaluation. Per example
from Jean-Gerard Pailloncy.
|
|
|
|
Per example from Florian Pflug.
|
|
in prettyprint mode. Andreas Pflug
|
|
|
|
|
|
|
|
is null-terminated. I think this is not a real bug because the parser
would always have truncated the identifier to NAMEDATALEN-1 already,
but let's be safe. Per report from Klocwork.
|
|
|
|
escapes --- they aren't simply quoted characters. Problem noted by
Antti Salmela. Also fix problem with incorrect handling of multibyte
characters when followed by a quantifier.
|
|
|
|
prevents problems when the DECLARE is in a portal and is executed
repeatedly, as is possible in v3 protocol. Per analysis by Oliver
Jowett, though I didn't use his patch exactly.
|
|
8.4.1). This corrects some curious regex bugs, though not the greediness
issue I was hoping to find a solution for :-(
|
|
error conditions during regexp compile, but not during regexp execution;
any sort of "can't happen" errors would be treated as no-match instead
of being reported as they should be. Noticed while trying to duplicate
a reported Tcl bug.
|
|
to disk right away. This is just a one-liner change rather than trying
to use FlushRelationBuffers().
|
|
avoid repalloc'ing twice when once is sufficient.
|
|
Prevent a backend crash when processing CREATE TABLE commands with
more than 65K columns, or when the created table has more than 65K columns
due to adding inherited columns from parent relations. Fix a similar
crash when processing SELECT queries with more than 65K target list
entries. In all three cases we would eventually detect the error and
elog, but the check was being made too late.
|
