summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2005-04-13Simplify initdb-time assignment of OIDs as I proposed yesterday, andTom Lane
avoid encroaching on the 'user' range of OIDs by allowing automatic OID assignment to use values below 16k until we reach normal operation. initdb not forced since this doesn't make any incompatible change; however a lot of stuff will have different OIDs after your next initdb.
2005-04-13Change addRangeTableEntryForRelation() to take a Relation pointer insteadTom Lane
of just a relation OID, thereby not having to open the relation for itself. This actually saves code rather than adding it for most of the existing callers, which had the rel open already. The main point though is to be able to use this rather than plain addRangeTableEntry in setTargetTable, thus saving one relation_openrv/relation_close cycle for every INSERT, UPDATE, or DELETE. Seems to provide a several percent win on simple INSERTs.
2005-04-13Revert yesterday's change to make pg_cast.h say 'OID = 0' in DATA entries.Tom Lane
On reflection, we ought to get rid of that mechanism entirely.
2005-04-12Adjust pg_cast.h so that the OIDs assigned to built-in casts come fromTom Lane
genbki.sh's pool (10000-16383) instead of being run-time assigned by heap_insert. Might as well use the pool as long as it's there ... I was a bit bemused to realize that it hadn't been in use at all since 7.2. initdb not forced since this doesn't really affect anything. The OIDs of casts and system indexes will change next time you do one, though.
2005-04-12Remove unnecessary UPDATE commands to assign explicit ACLs to functionsTom Lane
and PL languages during initdb. The default permissions for these objects are the same as what we were assigning anyway, so there is no need to expend space in the catalogs on them. The space cost is particularly significant in pg_proc's indexes, which are bloated by about a factor of 2 by the full-table update, and can never really recover the space. initdb not forced, since the change has no actual impact on behavior.
2005-04-12Revert mistaken renaming of UTF-8.Peter Eisentraut
2005-04-12Fix oversight in MIN/MAX optimization: must not return NULL entriesTom Lane
from index, since the aggregates ignore NULLs.
2005-04-12Add aggsortop column to pg_aggregate, so that MIN/MAX optimization canTom Lane
be supported for all datatypes. Add CREATE AGGREGATE and pg_dump support too. Add specialized min/max aggregates for bpchar, instead of depending on text's min/max, because otherwise the possible use of bpchar indexes cannot be recognized. initdb forced because of catalog changes.
2005-04-11Create the planner mechanism for optimizing simple MIN and MAX queriesTom Lane
into indexscans on matching indexes. For the moment, it only handles int4 and text datatypes; next step is to add a column to pg_aggregate so that all MIN/MAX aggregates can be handled. Per my recent proposal.
2005-04-11Fix interaction between materializing holdable cursors and firingTom Lane
deferred triggers: either one can create more work for the other, so we have to loop till it's all gone. Per example from andrew@supernews. Add a regression test to help spot trouble in this area in future.
2005-04-11PersistHoldablePortal must establish the correct value for ActiveSnapshotTom Lane
while completing execution of the cursor's query. Otherwise we get wrong answers or even crashes from non-volatile functions called by the query. Per report from andrew@supernews.
2005-04-10Make constant-folding produce sane output for COALESCE(NULL,NULL),Tom Lane
that is a plain NULL and not a COALESCE with no inputs. Fixes crash reported by Michael Williamson.
2005-04-10Split out into a separate function the code in grouping_planner() thatTom Lane
decides whether to use hashed grouping instead of sort-plus-uniq grouping. The function needs an annoyingly large number of parameters, but this still seems like a win for legibility, since it removes over a hundred lines from grouping_planner (which is still too big :-().
2005-04-10SQL functions returning pass-by-reference types were copying the resultsTom Lane
into the wrong memory context, resulting in a query-lifespan memory leak. Bug is new in 8.0, I believe. Per report from Rae Stiening.
2005-04-08If we're going to have a non-panic check for held_lwlocks[] overrun,Tom Lane
it must occur *before* we get into the critical state of holding a lock we have no place to record. Per discussion with Qingqing Zhou.
2005-04-08Use an always-there test, not an Assert, to check for overrun ofTom Lane
the held_lwlocks[] array. Per Qingqing Zhou.
2005-04-08Change the default setting of "add_missing_from" to false. This has beenNeil Conway
the long-term plan for this behavior for quite some time, but it is only possible now that DELETE has a USING clause so that the user can join other tables in a DELETE statement without relying on this behavior.
2005-04-08Use fork_process() to avoid some fork()-related boilerplate code whenNeil Conway
forking the stats collector child process.
2005-04-07Fix some issues with missing or too many newlines atTom Lane
end of file.
2005-04-07Allow plpgsql functions to omit RETURN command when the function returnsTom Lane
output parameters or VOID or a set. There seems no particular reason to insist on a RETURN in these cases, since the function return value is determined by other elements anyway. Per recent discussion.
2005-04-07Fix minor breakage to regression tests induced in previous commit -- I hadNeil Conway
updated the expected/ output, not the output/ output. Apologies.
2005-04-07Add a "USING" clause to DELETE, which is equivalent to the FROM clauseNeil Conway
in UPDATE. We also now issue a NOTICE if a query has _any_ implicit range table entries -- in the past, we would only warn about implicit RTEs in SELECTs with at least one explicit RTE. As a result of the warning change, 25 of the regression tests had to be updated. I also took the opportunity to remove some bogus whitespace differences between some of the float4 and float8 variants. I believe I have correctly updated all the platform-specific variants, but let me know if that's not the case. Original patch for DELETE ... USING from Euler Taveira de Oliveira, reworked by Neil Conway.
2005-04-06Apply the "nodeAgg" optimization to more of the builtin transitionNeil Conway
functions. This patch optimizes int2_sum(), int4_sum(), float4_accum() and float8_accum() to avoid needing to copy the transition function's state for each input tuple of the aggregate. In an extreme case (e.g. SELECT sum(int2_col) FROM table where table has a single column), it improves performance by about 20%. For more complex queries or tables with wider rows, the relative performance improvement will not be as significant.
2005-04-06Remove test for NULL node in ExecProcNode(). No place ever callsTom Lane
ExecProcNode() with a NULL value, so the test couldn't do anything for us except maybe mask bugs. Removing it probably doesn't save anything much either, but then again this is a hot-spot routine.
2005-04-06Merge Resdom nodes into TargetEntry nodes to simplify code and save aTom Lane
few palloc's. I also chose to eliminate the restype and restypmod fields entirely, since they are redundant with information stored in the node's contained expression; re-examining the expression at need seems simpler and more reliable than trying to keep restype/restypmod up to date. initdb forced due to change in contents of stored rules.
2005-04-06Attached patch cleans up the HTML code in tools/backend. This isBruce Momjian
required for us to pull it into the main website. Same kind of fixes as last time, just make sure things aren't violating the HTML standard. No context changes at all. Magnus Hagander
2005-04-06Include information about a domain's CHECK constraint, if any, in theNeil Conway
output of \dD in psql. From Greg Sabino Mullane.
2005-04-06This file was whacked by pgindent before it knew it shouldn't removeNeil Conway
braces around single statements (for PG_TRY macros). This patch fixes it. Alvaro Herrera.
2005-04-05Adjust grammar for plpgsql's OPEN command so that a cursor can beTom Lane
OPENed on non-SELECT commands such as EXPLAIN or SHOW (anything that returns tuples is allowed). This flexibility already existed for bound cursors, but OPEN was artificially restricting what it would take. Per a gripe some months back.
2005-04-05plpgsql does OUT parameters, as per my proposal a few weeks ago.Tom Lane
2005-04-04This patch changes int2_avg_accum() and int4_avg_accum() use the nodeAggNeil Conway
performance hack Tom introduced recently. This means we can avoid copying the transition array for each input tuple if these functions are invoked as aggregate transition functions. To test the performance improvement, I created a 1 million row table with a single int4 column. Without the patch, SELECT avg(col) FROM table took about 4.2 seconds (after the data was cached); with the patch, it took about 3.2 seconds. Naturally, the performance improvement for a less trivial query (or a table with wider rows) would be relatively smaller.
2005-04-04Minor fixes for psql tab completion. Spell "absolute" like the English word,Neil Conway
not the brand of vodka. Complete FETCH <sth> <sth> with FROM and IN, not FROM and TO (which is still pretty incomplete, but at least its the right syntax).
2005-04-04Remove an unused variable `ShmemBootstrap', and remove an obsoleteNeil Conway
comment. Patch from Alvaro.
2005-04-04In cost_mergejoin, the early-exit effect should not apply to theTom Lane
outer side of an outer join. Per andrew@supernews.
2005-04-01Second try at making examine_variable and friends behave sanely inTom Lane
cases with binary-compatible relabeling. My first try was implicitly assuming that all operators scalarineqsel is used for have binary- compatible datatypes on both sides ... which is very wrong of course. Per report from Michael Fuhr.
2005-04-01Make plperl work with OUT parameters.Tom Lane
2005-04-01Minor improvements in the really-pretty-ad-hoc test scripts for theTom Lane
PL languages.
2005-04-01Teach pg_dump about OUT parameters.Tom Lane
2005-04-01Update pgcvslog examples.Bruce Momjian
2005-04-01Fix wrong week returnded by date_trunc('week') for early dates inBruce Momjian
January --- would return wrong year for 2005-01-01 and 2006-01-01. per report from Robert Creager. Backpatch to 8.0.X.
2005-04-01Update pgcvslog examples.Bruce Momjian
2005-04-01Adjust pg_proc.proargtypes[0] tests in psql \df to handle new NULL valueBruce Momjian
for a function taking no arguments, per report from Michael Fuhr.
2005-03-31Flush any remaining statistics counts out to the collector at processTom Lane
exit. Without this, operations triggered during backend exit (such as temp table deletions) won't be counted ... which given heavy usage of temp tables can lead to pg_autovacuum falling way behind on the need to vacuum pg_class and pg_attribute. Per reports from Steve Crawford and others.
2005-03-31First phase of OUT-parameters project. We can now define and use SQLTom Lane
functions with OUT parameters. The various PLs still need work, as does pg_dump. Rudimentary docs and regression tests included.
2005-03-31Minor code cleanup: ExecHash() was returning a null TupleTableSlot, and anNeil Conway
old comment in the code claimed that this was necessary. Since it is not actually necessary any more, it is clearer to remove the comment and just return NULL instead -- the return value of ExecHash() is not used.
2005-03-29Add proallargtypes and proargmodes columns to pg_proc, as per my earlierTom Lane
proposal for OUT parameter support. The columns don't actually *do* anything yet, they are just left NULLs. But I thought I'd commit this part separately as a fairly pure example of the tasks needed when adding a column to pg_proc or one of the other core system tables.
2005-03-29Fix grammar for IN/OUT/INOUT parameters. This commit doesn't actuallyTom Lane
implement any new feature, it just pushes the 'not implemented' error message deeper into the backend. I also tweaked the grammar to accept Oracle-ish parameter syntax (parameter name first), as well as the SQL99 standard syntax (parameter mode first), since it was easy and people will doubtless try to use both anyway.
2005-03-29Officially decouple FUNC_MAX_ARGS from INDEX_MAX_KEYS, and set theTom Lane
former to 100 by default. Clean up some of the less necessary dependencies on FUNC_MAX_ARGS; however, the biggie (FunctionCallInfoData) remains.
2005-03-29Add SPI_getnspname(), including documentation.Neil Conway
2005-03-29Convert oidvector and int2vector into variable-length arrays. ThisTom Lane
change saves a great deal of space in pg_proc and its primary index, and it eliminates the former requirement that INDEX_MAX_KEYS and FUNC_MAX_ARGS have the same value. INDEX_MAX_KEYS is still embedded in the on-disk representation (because it affects index tuple header size), but FUNC_MAX_ARGS is not. I believe it would now be possible to increase FUNC_MAX_ARGS at little cost, but haven't experimented yet. There are still a lot of vestigial references to FUNC_MAX_ARGS, which I will clean up in a separate pass. However, getting rid of it altogether would require changing the FunctionCallInfoData struct, and I'm not sure I want to buy into that.