summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2011-01-17Fix miscalculation of itemsafter in array_set_slice().Tom Lane
If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitmap. This could result in trashing the array's data area (as seen in bug #5840 from Karsten Loesing), or worse. This has been broken since we first allowed the behavior of assigning to non-adjacent slices, in 8.2. Back-patch to all affected versions.
2011-01-17Increment Py_None refcount for NULL array elementsAlvaro Herrera
Per bug #5835 by Julien Demoor Author: Alex Hunsaker
2011-01-17Add getopt() support to test_fsync; also fix printf() format problem.Bruce Momjian
2011-01-17Set fallback_application_name in walreceiverMagnus Hagander
Makes replication slaves identify themselves in the new pg_stat_replication view.
2011-01-17Before exiting walreceiver, fsync() all the WAL received.Heikki Linnakangas
Otherwise WAL recovery will replay the un-flushed WAL after walreceiver has exited, which can lead to a non-recoverable standby if the system crashes hard at that point.
2011-01-16In test_fsync, use #define for printf format of ops/sec.Bruce Momjian
2011-01-15Use O_DIRECT in O_SYNC test of different size. Restructure O_DIRECTBruce Momjian
error reporting to be more consistent.
2011-01-15Reverse number of stars used for test_fsync details.Bruce Momjian
2011-01-15In test_fsync, warn about options without o_direct that are not used byBruce Momjian
Postgres, and cases where o_direct does not work with certain file systems.
2011-01-15Move a couple of declarations to reflect where the routines really are.Tom Lane
2011-01-15Add .gitignore to silence git complaints about parser/scanner output files.Tom Lane
2011-01-15Have test_fsync output details that fdatasync is the defaultBruce Momjian
wal_sync_method on Linux.
2011-01-15Restructure test_fync to use modular C so there is less duplicate codeBruce Momjian
and it can be enhanced easier.
2011-01-15Enumerate available tablespaces after starting the backupMagnus Hagander
This closes a race condition where if a tablespace was created after the enumeration happened but before the do_pg_start_backup() was called, the backup would be incomplete. Now that it's done while we are in backup mode, WAL replay will recreate it during restore. Noted by Heikki.
2011-01-15Improve output display of test_fsync.Bruce Momjian
2011-01-15Apply patch for test_fsync to add tests for O_DIRECT.Bruce Momjian
Adjusted patch by Josh Berkus
2011-01-15Treat a WAL sender process that hasn't started streaming yet as a regularHeikki Linnakangas
backend, as far as the postmaster shutdown logic is concerned. That means, fast shutdown will wait for WAL sender processes to exit before signaling bgwriter to finish. This avoids race conditions between a base backup stopping or starting, and bgwriter writing the shutdown checkpoint WAL record. We don't want e.g the end-of-backup WAL record to be written after the shutdown checkpoint.
2011-01-14Use a lexer and grammar for parsing walsender commandsMagnus Hagander
Makes it easier to parse mainly the BASE_BACKUP command with it's options, and avoids having to manually deal with quoted identifiers in the label (previously broken), and makes it easier to add new commands and options in the future. In passing, refactor the case statement in the walsender to put each command in it's own function.
2011-01-14Exit from base backups when shutdown is requestedMagnus Hagander
When the exit waits until the whole backup completes, it may take a very long time. In passing, add back an error check in the main loop so we detect clients that disconnect much earlier if the backup is large.
2011-01-13Code review for postmaster.pid contents changes.Tom Lane
Fix broken test for pre-existing postmaster, caused by wrong code for appending lines to the lockfile; don't write a failed listen_address setting into the lockfile; don't arbitrarily change the location of the data directory in the lockfile compared to previous releases; provide more consistent and useful definitions of the socket path and listen_address entries; avoid assuming that pg_ctl has the same DEFAULT_PGSOCKET_DIR as the postmaster; assorted code style improvements.
2011-01-13Revert incorrect memory-conservation hack in inheritance_planner().Tom Lane
This reverts commit d1001a78ce612a16ea622b558f5fc2b68c45ab4c of 2010-12-05, which was broken as reported by Jeff Davis. The problem is that the individual planning steps may have side-effects on substructures of PlannerGlobal, not only the current PlannerInfo root. Arranging to keep all such side effects in the main planning context is probably possible, but it would change this from a quick local hack into a wide-ranging and rather fragile endeavor. Which it's not worth.
2011-01-13Make sure walsender state is only read while holding the spinlockMagnus Hagander
Noted by Robert Haas.
2011-01-13Fix the logic in libpqrcv_receive() to determine if there's any incoming dataHeikki Linnakangas
that can be read without blocking. It used to conclude that there isn't, even though there was data in the socket receive buffer. That lead walreceiver to flush the WAL after every received chunk, potentially causing big performance issues. Backpatch to 9.0, because the performance impact can be very significant.
2011-01-13Workaround for recursive make breakagePeter Eisentraut
Changing a file two directory levels deep under src/backend/ would not cause the postgres binary to be rebuilt. This change fixes it, but no one knows why.
2011-01-13Don't run regression tests in SQL_ASCII encoding by defaultPeter Eisentraut
Instead, run them in the encoding that the locale selects, which is more representative of real use. Also document how locale and encoding for regression test runs can be selected.
2011-01-12Fix PlanRowMark/ExecRowMark structures to handle inheritance correctly.Tom Lane
In an inherited UPDATE/DELETE, each target table has its own subplan, because it might have a column set different from other targets. This means that the resjunk columns we add to support EvalPlanQual might be at different physical column numbers in each subplan. The EvalPlanQual rewrite I did for 9.0 failed to account for this, resulting in possible misbehavior or even crashes during concurrent updates to the same row, as seen in a recent report from Gordon Shannon. Revise the data structure so that we track resjunk column numbers separately for each subplan. I also chose to move responsibility for identifying the physical column numbers back to executor startup, instead of assuming that numbers derived during preprocess_targetlist would stay valid throughout subsequent massaging of the plan. That's a bit slower, so we might want to consider undoing it someday; but it would complicate the patch considerably and didn't seem justifiable in a bug fix that has to be back-patched to 9.0.
2011-01-12Revert patch adding support for logging the current role.Robert Haas
This reverts commit a8a8867912c46a68c9ac14903b3dba2fab8f7097, committed by me earlier today (2011-01-12). This isn't safe inside an aborted transaction. Noted by Tom Lane.
2011-01-12Add support for logging the current role.Robert Haas
Stephen Frost, with some editorialization by me.
2011-01-11Unbreak regression tests, apparently broken by commit 4c8e20fAndrew Dunstan
2011-01-12Re-add recursive coverage target in src/backend/Peter Eisentraut
This was lost during the recent recursive make change.
2011-01-11Track walsender state in shared memory and expose in pg_stat_replicationMagnus Hagander
2011-01-11Add missing function prototype, for consistencyMagnus Hagander
2011-01-11Adjust basebackup.c to suppress compiler warnings.Tom Lane
Some versions of gcc complain about "variable `tablespaces' might be clobbered by `longjmp' or `vfork'" with the original coding. Fix by moving the PG_TRY block into a separate subroutine.
2011-01-11Tweak create_index_paths()'s test for whether to consider a bitmap scan.Tom Lane
Per my note of a couple days ago, create_index_paths would refuse to consider any path at all for GIN indexes if the selectivity estimate came out as 1.0; not even if you tried to force it with enable_seqscan. While this isn't really a bad outcome in practice, it could be annoying for testing purposes. Adjust the test for "is this path only useful for sorting" so that it doesn't fire on paths with nil pathkeys, which will include all GIN paths.
2011-01-11Reset walsender ps title in the main loopMagnus Hagander
When in streaming mode we can never get out, so it will never be required, but after a base backup (or other operations) we can get back to the loop, so the title needs to be cleared.
2011-01-10Set process title to indicate base backup is runningMagnus Hagander
2011-01-10Leave temporary files out of streaming base backups.Heikki Linnakangas
2011-01-10Backend support for streaming base backupsMagnus Hagander
Add BASE_BACKUP command to walsender, allowing it to stream a base backup to the client (in tar format). The syntax is still far from ideal, that will be fixed in the switch to use a proper grammar for walsender. No client included yet, will come as a separate commit. Magnus Hagander and Heikki Linnakangas
2011-01-09Split pg_start_backup() and pg_stop_backup() into two piecesMagnus Hagander
Move the actual functionality into a separate function that's easier to call internally, and change the SQL-callable function to be a wrapper calling this. Also create a pg_abort_backup() function, only callable internally, that does only the most vital parts of pg_stop_backup(), making it safe(r) to call from error handlers.
2011-01-09Fix crash in the new GiST insertion code, when an update splits the root page.Heikki Linnakangas
This bug was exercised by contrib/intarray/bench, as noted by Tom Lane.
2011-01-09Fix up core tsquery GIN support for new extractQuery API.Tom Lane
No need for the empty-prefix-match kluge to force a full scan anymore.
2011-01-09Use array_contains_nulls instead of ARR_HASNULL on user-supplied arrays.Tom Lane
This applies the fix for bug #5784 to remaining places where we wish to reject nulls in user-supplied arrays. In all these places, there's no reason not to allow a null bitmap to be present, so long as none of the current elements are actually null. I did not change some other places where we are looking at system catalog entries or aggregate transition values, as the presence of a null bitmap in such an array would be suspicious.
2011-01-09Ensure the directory for gram.h is created on win32Magnus Hagander
Result of bad testing of my last commit.
2011-01-09Properly install gram.h on MSVC buildsMagnus Hagander
This file is now needed by pgAdmin builds, which started failing since it was missing in the installer builds.
2011-01-09Add pgreadlink() on Windows to read junction pointsMagnus Hagander
Add support for reading back information about the symbolic links we've created with pgsymlink(), which are actually Junction Points. Just like pgsymlink() can only create directory symlinks, pgreadlink() can only read directory symlinks.
2011-01-09There is no need to have to identical functions in ecpg thus removing one of ↵Michael Meskes
them.
2011-01-08Add array_contains_nulls() function in arrayfuncs.c.Tom Lane
This will support fixing contrib/intarray (and probably other places) so that they don't have to fail on arrays that contain a null bitmap but no live null entries.
2011-01-08Fix up gincostestimate for new extractQuery API.Tom Lane
The only reason this wasn't crashing while testing the core anyarray operators was that it was disabled for those cases because of passing the wrong type information to get_opfamily_proc :-(. So fix that too, and make it insist on finding the support proc --- in hindsight, silently doing nothing is not as sane a coping mechanism as all that.
2011-01-08In ecpg's parser removed a fixed length limit for constants defining an ↵Michael Meskes
array dimension.
2011-01-08Remove pg_am.amindexnulls.Tom Lane
The only use we have had for amindexnulls is in determining whether an index is safe to cluster on; but since the addition of the amclusterable flag, that usage is pretty redundant. In passing, clean up assorted sloppiness from the last patch that touched pg_am.h: Natts_pg_am was wrong, and ambuildempty was not documented.