summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2006-10-03Fix yesno_prompt() memory leak in /script tools, reported by Converity.Bruce Momjian
2006-10-03Improve numeric overflow error message.Bruce Momjian
David Fetter
2006-10-03Make some sentences consistent with similar ones.Bruce Momjian
Euler Taveira de Oliveira
2006-10-03The attached patch changes units of the some default values inBruce Momjian
postgresql.conf. - shared_buffers = 32000kB => 32MB - temp_buffers = 8000kB => 8MB - wal_buffers = 8 => 64kB The code of initdb was a bit modified to write MB-unit values. Values greater than 8000kB are rounded out to MB. GUC_UNIT_XBLOCKS is added for wal_buffers. It is like GUC_UNIT_BLOCKS, but uses XLOG_BLCKSZ instead of BLCKSZ. Also, I cleaned up the test of GUC_UNIT_* flags in preparation to add more unit flags in less bits. ITAGAKI Takahiro
2006-10-03Cleanup pgwin32_open() 'if' test, and avoid possible error.Bruce Momjian
2006-10-03Rearrange MSVC errcode hack, fix incorrect _MSC_VER test. MagnusTom Lane
2006-10-03Move WIN32_ONLY_COMPILER define from c.h to win32.h because it was beingBruce Momjian
defined too late.
2006-10-03Mention in postgresql.conf that autovacuum also needsBruce Momjian
stats_start_collector and stats_row_level to also be on David Wheeler
2006-10-02Add URL about strlcpy() creation history.Bruce Momjian
2006-10-02Properly handle the case where strlcpy() exists in libc but isn'tTom Lane
declared in the system headers. Per report from Bruce than some BSDen are like this.
2006-10-01Make some marginal performance improvements in reportErrorPosition(),Tom Lane
which turns out to be a dominant part of the runtime in scenarios involving lots of parse-time warnings (such as Stephen Frost's example of an INSERT with a lot of backslash-containing strings). There's not a whole lot we can do about the character-at-a-time scanning, but we can at least avoid traversing the query twice.
2006-10-01Do a CHECK_FOR_INTERRUPTS after emitting a message of less than ERRORTom Lane
severity. This is to ensure the user can cancel a query that's spitting out lots of notice/warning messages, even if they're coming from a loop that doesn't otherwise contain a CHECK_FOR_INTERRUPTS. Per gripe from Stephen Frost.
2006-10-01Fix overly enthusiastic Assert introduced in 8.1: it's expecting aTom Lane
CaseTestExpr, but forgot that the optimizer is sometimes able to replace CaseTestExpr by Const.
2006-09-30BSD/OS doesn't have a prototype for strlcpy() but has the function, soBruce Momjian
work around that with defines.
2006-09-29Allow assignment to array elements not contiguous with those alreadyTom Lane
present; intervening positions are filled with nulls. This behavior is required by SQL99 but was not implementable before 8.2 due to lack of support for nulls in arrays. I have only made it work for the one-dimensional case, which is all that SQL99 requires. It seems quite complex to get it right in higher dimensions, and since we never allowed extension at all in higher dimensions, I think that must count as a future feature addition not a bug fix.
2006-09-28Fix IS NULL and IS NOT NULL tests on row-valued expressions to conform toTom Lane
the SQL spec, viz IS NULL is true if all the row's fields are null, IS NOT NULL is true if all the row's fields are not null. The former coding got this right for a limited number of cases with IS NULL (ie, those where it could disassemble a ROW constructor at parse time), but was entirely wrong for IS NOT NULL. Per report from Teodor. I desisted from changing the behavior for arrays, since on closer inspection it's not clear that there's any support for that in the SQL spec. This probably needs more consideration.
2006-09-28Fix a couple other places that need to know about (some) src/port/ filesTom Lane
explicitly.
2006-09-27Oops, forgot that libpq needs extra steps to make use of src/port/ files.Tom Lane
2006-09-27Replace strncpy with strlcpy in selected places that seem possibly relevantTom Lane
to performance. (A wholesale effort to get rid of strncpy should be undertaken sometime, but not during beta.) This commit also fixes dynahash.c to correctly truncate overlength string keys for hashtables, so that its callers don't have to anymore.
2006-09-27Add strlcpy() to the set of functions supported by src/port/ when notTom Lane
available directly on the platform. Per discussion, this function is sufficiently widely recognized to be treated as standard.
2006-09-27Fix some misuses of strncat().Tom Lane
2006-09-27Remove separate strdup.h header file; it's redundant with port.h.Tom Lane
2006-09-26Degrade the transaction-id wraparound point message from LOG to DEBUG1, perAlvaro Herrera
discussion. Patch from Simon Riggs.
2006-09-26Added new filesMichael Meskes
2006-09-26Added Joachim's changes for MinGW.Michael Meskes
Added SET DATESTYLE to one test so the output format is defined.
2006-09-25Increase default value of effective_cache_size to 128MB, per discussion.Tom Lane
2006-09-25Add a check to prevent overwriting valid data if smgrnblocks() gives aTom Lane
wrong answer, as has been seen to occur with a buggy Linux kernel. Not really our bug, but it's a simple test in a seldom-used control path, so might as well have a defense.
2006-09-25Fix notice message from DROP FUNCTION IF EXISTS, and improve messageTom Lane
for DROP AGGREGATE IF EXISTS. Per report from Teodor.
2006-09-24Fix incorrect mapping of fopen mode 'a' in recently-added code toTom Lane
make fopen work safely on Windows. Magnus
2006-09-24Cause pg_regress to invoke the temporary postmaster as 'postgres' notTom Lane
'postmaster', so as not to depend on the existence of the postmaster symlink. Also, implement postmaster-still-alive and postmaster-kill operations for Windows, per Magnus.
2006-09-24Suppress useless warning on pre-XP versions of Windows. MagnusTom Lane
2006-09-23Tag us Beta1REL8_2_BETA1PostgreSQL Daemon
2006-09-22Fix pg_locks view to call advisory locks advisory locks, while preservingTom Lane
backward compatibility for anyone using the old userlock code that's now on pgfoundry --- locks from that code still show as 'userlock'.
2006-09-22Fix bugs in plpgsql and ecpg caused by assuming that isspace() would onlyTom Lane
return true for exactly the characters treated as whitespace by their flex scanners. Per report from Victor Snezhko and subsequent investigation. Also fix a passel of unsafe usages of <ctype.h> functions, that is, ye olde char-vs-unsigned-char issue. I won't miss <ctype.h> when we are finally able to stop using it.
2006-09-22Surely this temp buffer needn't be static.Tom Lane
2006-09-22Rearrange yes/no prompting code so that the prompts always show thePeter Eisentraut
(possibly (un)translated) letters that are actually expected as input. Also reject invalid responses instead of silenty taken them as "no". with help from Bernd Helmle
2006-09-22Add units to the default postgresql.conf. For the most part, this shouldPeter Eisentraut
match what SHOW displays as default value, to make the user experience uniform.
2006-09-21Fix free space map to correctly track the total amount of FSM space neededTom Lane
even when a single relation requires more than max_fsm_pages pages. Also, make VACUUM emit a warning in this case, since it likely means that VACUUM FULL or other drastic corrective measure is needed. Per reports from Jeff Frost and others of unexpected changes in the claimed max_fsm_pages need.
2006-09-20Change patternsel (LIKE/regex selectivity estimation) so that if thereTom Lane
is a large enough histogram, it will use the number of matches in the histogram to derive a selectivity estimate, rather than the admittedly pretty bogus heuristics involving examining the pattern contents. I set 'large enough' at 100, but perhaps we should change that later. Also apply the same technique in contrib/ltree's <@ and @> estimator. Per discussion with Stefan Kaltenbrunner and Matteo Beccati.
2006-09-19Improve usage of effective_cache_size parameter by assuming that all theTom Lane
tables in the query compete for cache space, not just the one we are currently costing an indexscan for. This seems more realistic, and it definitely will help in examples recently exhibited by Stefan Kaltenbrunner. To get the total size of all the tables involved, we must tweak the handling of 'append relations' a bit --- formerly we looked up information about the child tables on-the-fly during set_append_rel_pathlist, but it needs to be done before we start doing any cost estimation, so push it into the add_base_rels_to_query scan.
2006-09-19Fix shared library creation to work properly on AIX. Albe LaurenzTom Lane
2006-09-18Add built-in userlock manipulation functions to replace the formerTom Lane
contrib functionality. Along the way, remove the USER_LOCKS configuration symbol, since it no longer makes any sense to try to compile that out. No user documentation yet ... mmoncure has promised to write some. Thanks to Abhijit Menon-Sen for creating a first draft to work from.
2006-09-18Fix problems with column name list of CREATE TABLE AS being applied toTom Lane
the input query's target list too soon, causing it to affect processing of ORDER BY in the input query.
2006-09-18Fix CREATE TABLE ... AS VALUES ... to work rather than Assert'ing;Tom Lane
oversight in original implementation of VALUES. Also fix an oversight in recent addition of options to CREATE TABLE AS: they weren't getting propagated if the query was a set-operation such as UNION.
2006-09-17Change ANALYZE to take ShareUpdateExclusiveLock not AccessShareLock onTom Lane
the table being analyzed. This prevents two ANALYZEs from running concurrently on the same table and possibly suffering concurrent-update failures while trying to store their results into pg_statistic. The downside is that a database-wide ANALYZE executed within a transaction block will hold ShareUpdateExclusiveLock on many tables simultaneously, which could lead to concurrency issues or even deadlock against another such ANALYZE. However, this seems a corner case of less importance than getting unexpected errors from a foreground ANALYZE when autovacuum elects to analyze the same table concurrently. Per discussion.
2006-09-17Marginal cleanup in arrangements for ensuring StrategyHintVacuum is clearedTom Lane
after an error during VACUUM. We have a PG_TRY block anyway around the only call sites, so just reset it in the CATCH clause instead of having AtEOXact_Buffers blindly do it during xact end. I think the old code was actively wrong for the case of a failure during ANALYZE inside a subtransaction --- the flag wouldn't get cleared until main transaction end. Probably not worth back-patching though.
2006-09-16Rename the recently-added pg_timezonenames view to pg_timezone_abbrevs,Tom Lane
and create a new view pg_timezone_names that provides information about the zones known in the 'zic' database. Magnus Hagander, with some additional work by Tom Lane.
2006-09-16Update timezone data files to release 2006k of the zic database.Tom Lane
2006-09-16Define errcode as __msvc_errcode not __vc_errcode for MSVC builds,Tom Lane
per Magnus.
2006-09-15Several fixes for MSVC build scripts, from Magnus.Tom Lane