From 5484c0a9806b3e90b483128bc386054fc432cb65 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 14 Jun 2016 10:47:06 -0400 Subject: Minor fixes in contrib installation scripts. Extension scripts should never use CREATE OR REPLACE for initial object creation. If there is a collision with a pre-existing (probably user-created) object, we want extension installation to fail, not silently overwrite the user's object. Bloom and sslinfo both violated this precept. Also fix a number of scripts that had no standard header (the file name comment and the \echo...\quit guard). Probably the \echo...\quit hack is less important now than it was in 9.1 days, but that doesn't mean that individual extensions get to choose whether to use it or not. And fix a couple of evident copy-and-pasteos in file name comments. No need for back-patch: the REPLACE bugs are both new in 9.6, and the rest of this is pretty much cosmetic. Andreas Karlsson and Tom Lane --- contrib/hstore_plpython/hstore_plpythonu--1.0.sql | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'contrib/hstore_plpython/hstore_plpythonu--1.0.sql') diff --git a/contrib/hstore_plpython/hstore_plpythonu--1.0.sql b/contrib/hstore_plpython/hstore_plpythonu--1.0.sql index e2e4721dca9..d79bdc96d99 100644 --- a/contrib/hstore_plpython/hstore_plpythonu--1.0.sql +++ b/contrib/hstore_plpython/hstore_plpythonu--1.0.sql @@ -1,3 +1,8 @@ +/* contrib/hstore_plpython/hstore_plpythonu--1.0.sql */ + +-- complain if script is sourced in psql, rather than via CREATE EXTENSION +\echo Use "CREATE EXTENSION hstore_plpythonu" to load this file. \quit + -- make sure the prerequisite libraries are loaded LOAD 'plpython2'; -- change to plpython3 if that ever becomes the default SELECT NULL::hstore; -- cgit v1.2.3