From 92b7902deb3155f6975f33e8b6c8be4d9d066172 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 21 Mar 2016 11:59:49 -0400 Subject: Clean up some Coverity complaints about commit 0bf3ae88af330496. The two get_tle_by_resno() calls introduced by this commit lacked any check for a NULL return, unlike any other calls of that function anywhere in our tree. Coverity quite properly complained about it. Also fix a misindented line in process_query_params(), which Coverity also complained about on the grounds that the bad indentation suggested possible programmer misinterpretation. --- contrib/postgres_fdw/deparse.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'contrib/postgres_fdw/deparse.c') diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index d1c82597ec3..bdc410d1a35 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -1356,6 +1356,10 @@ deparseDirectUpdateSql(StringInfo buf, PlannerInfo *root, int attnum = lfirst_int(lc); TargetEntry *tle = get_tle_by_resno(targetlist, attnum); + if (!tle) + elog(ERROR, "attribute number %d not found in UPDATE targetlist", + attnum); + if (!first) appendStringInfoString(buf, ", "); first = false; -- cgit v1.2.3