From 611806cd726fc92989ac918eac48fd8d684869c7 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 26 Oct 2023 09:16:25 +0200 Subject: Add trailing commas to enum definitions Since C99, there can be a trailing comma after the last value in an enum definition. A lot of new code has been introducing this style on the fly. Some new patches are now taking an inconsistent approach to this. Some add the last comma on the fly if they add a new last value, some are trying to preserve the existing style in each place, some are even dropping the last comma if there was one. We could nudge this all in a consistent direction if we just add the trailing commas everywhere once. I omitted a few places where there was a fixed "last" value that will always stay last. I also skipped the header files of libpq and ecpg, in case people want to use those with older compilers. There were also a small number of cases where the enum type wasn't used anywhere (but the enum values were), which ended up confusing pgindent a bit, so I left those alone. Discussion: https://www.postgresql.org/message-id/flat/386f8c45-c8ac-4681-8add-e3b0852c1620%40eisentraut.org --- contrib/postgres_fdw/postgres_fdw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'contrib/postgres_fdw/postgres_fdw.h') diff --git a/contrib/postgres_fdw/postgres_fdw.h b/contrib/postgres_fdw/postgres_fdw.h index 02c11523199..47157ac887e 100644 --- a/contrib/postgres_fdw/postgres_fdw.h +++ b/contrib/postgres_fdw/postgres_fdw.h @@ -143,7 +143,7 @@ typedef enum PgFdwSamplingMethod ANALYZE_SAMPLE_AUTO, /* choose by server version */ ANALYZE_SAMPLE_RANDOM, /* remote random() */ ANALYZE_SAMPLE_SYSTEM, /* TABLESAMPLE system */ - ANALYZE_SAMPLE_BERNOULLI /* TABLESAMPLE bernoulli */ + ANALYZE_SAMPLE_BERNOULLI, /* TABLESAMPLE bernoulli */ } PgFdwSamplingMethod; /* in postgres_fdw.c */ -- cgit v1.2.3