From d47a1136e441cebe7ae7fe72d70eb8ce278d5cd6 Mon Sep 17 00:00:00 2001
From: Andres Freund <andres@anarazel.de>
Date: Sat, 27 Jun 2015 18:49:00 +0200
Subject: Fix test_decoding's handling of nonexistant columns in old tuple
 versions.

test_decoding used fastgetattr() to extract column values. That's wrong
when decoding updates and deletes if a table's replica identity is set
to FULL and new columns have been added since the old version of the
tuple was created. Due to the lack of a crosscheck with the datum's
natts values an invalid value will be output, leading to errors or
worse.

Bug: #13470
Reported-By: Krzysztof Kotlarski
Discussion: 20150626100333.3874.90852@wrigleys.postgresql.org

Backpatch to 9.4, where the feature, including the bug, was added.
---
 contrib/test_decoding/sql/ddl.sql | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'contrib/test_decoding/sql/ddl.sql')

diff --git a/contrib/test_decoding/sql/ddl.sql b/contrib/test_decoding/sql/ddl.sql
index 9c0502f1558..e311c5966e0 100644
--- a/contrib/test_decoding/sql/ddl.sql
+++ b/contrib/test_decoding/sql/ddl.sql
@@ -277,6 +277,10 @@ ALTER TABLE table_without_key REPLICA IDENTITY FULL;
 UPDATE table_without_key SET data = 3 WHERE data = 2;
 UPDATE table_without_key SET id = -id;
 UPDATE table_without_key SET id = -id;
+-- ensure that FULL correctly deals with new columns
+ALTER TABLE table_without_key ADD COLUMN new_column text;
+UPDATE table_without_key SET id = -id;
+UPDATE table_without_key SET id = -id, new_column = 'someval';
 DELETE FROM table_without_key WHERE data = 3;
 
 CREATE TABLE table_with_pkey(id serial primary key, data int);
-- 
cgit v1.2.3

