From 8a37a0341e9ec4ecd25ff5caa400f6367742f9e3 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 1 Mar 2010 05:17:08 +0000 Subject: Remove xmlCleanupParser calls from contrib/xml2. These are unnecessary and probably dangerous. I don't see any immediate risk situations in the core XML support or contrib/xml2 itself, but there could be issues with external uses of libxml2, and in any case it's an accident waiting to happen. --- contrib/xml2/xslt_proc.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'contrib/xml2/xslt_proc.c') diff --git a/contrib/xml2/xslt_proc.c b/contrib/xml2/xslt_proc.c index 18d9879fcfc..bf7ef89042f 100644 --- a/contrib/xml2/xslt_proc.c +++ b/contrib/xml2/xslt_proc.c @@ -80,7 +80,6 @@ xslt_process(PG_FUNCTION_ARGS) if (doctree == NULL) { - xmlCleanupParser(); elog_error("Error parsing XML document", false); PG_RETURN_NULL(); @@ -94,7 +93,6 @@ xslt_process(PG_FUNCTION_ARGS) if (ssdoc == NULL) { xmlFreeDoc(doctree); - xmlCleanupParser(); elog_error("Error parsing stylesheet as XML document", false); PG_RETURN_NULL(); } @@ -109,7 +107,6 @@ xslt_process(PG_FUNCTION_ARGS) { xmlFreeDoc(doctree); xsltCleanupGlobals(); - xmlCleanupParser(); elog_error("Failed to parse stylesheet", false); PG_RETURN_NULL(); } @@ -122,7 +119,6 @@ xslt_process(PG_FUNCTION_ARGS) xmlFreeDoc(doctree); xsltCleanupGlobals(); - xmlCleanupParser(); if (resstat < 0) PG_RETURN_NULL(); -- cgit v1.2.3