From 3756c65a0764bca1ba104dfa87d8f2cf7f885311 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 1 Oct 2015 16:19:49 -0400 Subject: Fix pg_dump to handle inherited NOT VALID check constraints correctly. This case seems to have been overlooked when unvalidated check constraints were introduced, in 9.2. The code would attempt to dump such constraints over again for each child table, even though adding them to the parent table is sufficient. In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make clean" target fully cleans up after a failed test. This evidently got dealt with at some point in 9.4, but it wasn't back-patched. I ran into it while testing this fix ... Per bug #13656 from Ingmar Brouns. --- contrib/pg_upgrade/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'contrib') diff --git a/contrib/pg_upgrade/Makefile b/contrib/pg_upgrade/Makefile index dec57a6130d..e18522e2b53 100644 --- a/contrib/pg_upgrade/Makefile +++ b/contrib/pg_upgrade/Makefile @@ -11,7 +11,9 @@ OBJS = check.o controldata.o dump.o exec.o file.o function.o info.o \ PG_CPPFLAGS = -DFRONTEND -DDLSUFFIX=\"$(DLSUFFIX)\" -I$(srcdir) -I$(libpq_srcdir) PG_LIBS = $(libpq_pgport) -EXTRA_CLEAN = analyze_new_cluster.sh delete_old_cluster.sh log/ tmp_check/ +EXTRA_CLEAN = analyze_new_cluster.sh delete_old_cluster.sh log/ tmp_check/ \ + pg_upgrade_dump_*.sql \ + pg_upgrade_dump_*.custom pg_upgrade_*.log ifdef USE_PGXS PG_CONFIG = pg_config -- cgit v1.2.3