From a160e92779afb1146474585a943454eab8432ea0 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 7 Jun 2024 13:27:26 -0400 Subject: Fix behavior of stable functions called from a CALL's argument list. If the CALL is within an atomic context (e.g. there's an outer transaction block), _SPI_execute_plan should acquire a fresh snapshot to execute any such functions with. We failed to do that and instead passed them the Portal snapshot, which had been acquired at the start of the current SQL command. This'd lead to seeing stale values of rows modified since the start of the command. This is arguably a bug in 84f5c2908: I failed to see that "are we in non-atomic mode" needs to be defined the same way as it is further down in _SPI_execute_plan, i.e. check !_SPI_current->atomic not just options->allow_nonatomic. Alternatively the blame could be laid on plpgsql, which is unconditionally passing allow_nonatomic = true for CALL/DO even when it knows it's in an atomic context. However, fixing it in spi.c seems like a better idea since that will also fix the problem for any extensions that may have copied plpgsql's coding pattern. While here, update an obsolete comment about _SPI_execute_plan's snapshot management. Per report from Victor Yegorov. Back-patch to all supported versions. Discussion: https://postgr.es/m/CAGnEboiRe+fG2QxuBO2390F7P8e2MQ6UyBjZSL_w1Cej+E4=Vw@mail.gmail.com --- doc/src/sgml/spi.sgml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/spi.sgml b/doc/src/sgml/spi.sgml index 47f4b5b4317..5c36b534902 100644 --- a/doc/src/sgml/spi.sgml +++ b/doc/src/sgml/spi.sgml @@ -742,7 +742,9 @@ int SPI_execute_extended(const char *command, true allows non-atomic execution of CALL and DO - statements + statements (but this field is ignored unless + the SPI_OPT_NONATOMIC flag was passed + to SPI_connect_ext) @@ -1883,7 +1885,9 @@ int SPI_execute_plan_extended(SPIPlanPtr plan, true allows non-atomic execution of CALL and DO - statements + statements (but this field is ignored unless + the SPI_OPT_NONATOMIC flag was passed + to SPI_connect_ext) -- cgit v1.2.3