From bca409e5b160f81ccd980bef2aeb32f8b731b0fd Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 21 Jul 2020 12:38:08 -0400 Subject: Assert that we don't insert nulls into attnotnull catalog columns. The executor checks for this error, and so does the bootstrap catalog loader, but we never checked for it in retail catalog manipulations. The folly of that has now been exposed, so let's add assertions checking it. Checking in CatalogTupleInsert[WithInfo] and CatalogTupleUpdate[WithInfo] should be enough to cover this. Back-patch to v10; the aforesaid functions didn't exist before that, and it didn't seem worth adapting the patch to the oldest branches. But given the risk of JIT crashes, I think we certainly need this as far back as v11. Pre-v13, we have to explicitly exclude pg_subscription.subslotname and pg_subscription_rel.srsublsn from the checks, since they are mismarked. (Even if we change our mind about applying BKI_FORCE_NULL in the branch tips, it doesn't seem wise to have assertions that would fire in existing databases.) Discussion: https://postgr.es/m/298837.1595196283@sss.pgh.pa.us --- doc/src/sgml/bki.sgml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/bki.sgml b/doc/src/sgml/bki.sgml index 6776c4a3c18..4e7568f5ce9 100644 --- a/doc/src/sgml/bki.sgml +++ b/doc/src/sgml/bki.sgml @@ -122,10 +122,7 @@ if they are fixed-width and are not preceded by any nullable column. Where this rule is inadequate, you can force correct marking by using BKI_FORCE_NOT_NULL - and BKI_FORCE_NULL annotations as needed. But note - that NOT NULL constraints are only enforced in the - executor, not against tuples that are generated by random C code, - so care is still needed when manually creating or updating catalog rows. + and BKI_FORCE_NULL annotations as needed. -- cgit v1.2.3