From cd29be5459f0e138c0f19d49ee588feeda78e3c9 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Tue, 2 Nov 2021 22:49:57 +0900 Subject: pgbench: Improve error-handling in pgbench. Previously failures of initial connection and logfile open caused pgbench to proceed the benchmarking, report the incomplete results and exit with status 2. It didn't make sense to proceed the benchmarking even when pgbench could not start as prescribed. This commit improves pgbench so that early errors that occur when starting benchmark such as those failures should make pgbench exit immediately with status 1. Author: Yugo Nagata Reviewed-by: Fabien COELHO, Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/TYCPR01MB5870057375ACA8A73099C649F5349@TYCPR01MB5870.jpnprd01.prod.outlook.com --- doc/src/sgml/ref/pgbench.sgml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml index 0f432767c25..c71dab644ca 100644 --- a/doc/src/sgml/ref/pgbench.sgml +++ b/doc/src/sgml/ref/pgbench.sgml @@ -904,10 +904,12 @@ pgbench options d A successful run will exit with status 0. Exit status 1 indicates static - problems such as invalid command-line options. Errors during the run such - as database errors or problems in the script will result in exit status 2. - In the latter case, pgbench will print partial - results. + problems such as invalid command-line options or internal errors which + are supposed to never occur. Early errors that occur when starting + benchmark such as initial connection failures also exit with status 1. + Errors during the run such as database errors or problems in the script + will result in exit status 2. In the latter case, + pgbench will print partial results. -- cgit v1.2.3