From f140007050a2ba874b85c4578d8417828f4b64b6 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 31 Jul 2019 09:42:15 +0200 Subject: Run UTF8-requiring collation tests by default The tests collate.icu.utf8 and collate.linux.utf8 were previously only run when explicitly selected via EXTRA_TESTS. They require a UTF8 database, because the error messages in the expected files refer to that, and they use some non-ASCII characters in the tests. Since users can select any locale and encoding for the regression test run, it was not possible to include these tests automatically. To fix, use psql's \if facility to check various prerequisites such as platform and the server encoding and quit the tests at the very beginning if the configuration is not adequate. We then need to maintain alternative expected files for these tests, but they are very tiny and never need to change after this. These two tests are now run automatically as part of the regression tests. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/052295c2-a2e1-9a21-bd36-8fbff8686cf3%402ndquadrant.com --- doc/src/sgml/regress.sgml | 8 -------- 1 file changed, 8 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/regress.sgml b/doc/src/sgml/regress.sgml index 7b682132668..d98187c970e 100644 --- a/doc/src/sgml/regress.sgml +++ b/doc/src/sgml/regress.sgml @@ -363,14 +363,6 @@ make check LANG=C ENCODING=EUC_JP make check EXTRA_TESTS=numeric_big - To run the collation tests: - -make check EXTRA_TESTS='collate.linux.utf8 collate.icu.utf8' LANG=en_US.utf8 - - The collate.linux.utf8 test works only on Linux/glibc - platforms. The collate.icu.utf8 test only works when - support for ICU was built. Both tests will only succeed when run in a - database that uses UTF-8 encoding. -- cgit v1.2.3