From deba7c6fc3ccbaadfccbf70f73480d33a27b15b4 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 8 Sep 2019 17:00:29 -0400 Subject: Fix RelationIdGetRelation calls that weren't bothering with error checks. Some of these are quite old, but that doesn't make them not bugs. We'd rather report a failure via elog than SIGSEGV. While at it, uniformly spell the error check as !RelationIsValid(rel) rather than a bare rel == NULL test. The machine code is the same but it seems better to be consistent. Coverity complained about this today, not sure why, because the mistake is in fact old. --- src/backend/access/heap/heapam.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/backend/access/heap/heapam.c') diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index d00f4f23e5f..f8914f778c0 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -7976,6 +7976,10 @@ ExtractReplicaIdentity(Relation relation, HeapTuple tp, bool key_changed, bool * } idx_rel = RelationIdGetRelation(replidindex); + + if (!RelationIsValid(idx_rel)) + elog(ERROR, "could not open relation with OID %u", replidindex); + idx_desc = RelationGetDescr(idx_rel); /* deform tuple, so we have fast access to columns */ -- cgit v1.2.3