From cd38b7e77315c729ea1e52ca7b8bb0d7c20d2a3b Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Tue, 25 Nov 2025 16:39:56 -0500 Subject: Assert that cutoffs are provided if freezing will be attempted MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit heap_page_prune_and_freeze() requires the caller to initialize PruneFreezeParams->cutoffs so that the function can correctly evaluate whether tuples should be frozen. This requirement previously existed only in comments and was easy to miss, especially after “cutoffs” was converted from a direct function parameter to a field of the newly introduced PruneFreezeParams struct (added in 1937ed70621). Adding an assert makes this requirement explicit and harder to violate. Also, fix a minor typo while we're at it. Author: Chao Li Reviewed-by: Melanie Plageman Discussion: https://postgr.es/m/0AC177F5-5E26-45EE-B273-357C51212AC5%40gmail.com --- src/backend/access/heap/pruneheap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/backend/access/heap/pruneheap.c') diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index 0d6311088ea..ac958d86374 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -461,7 +461,7 @@ heap_page_will_freeze(Relation relation, Buffer buffer, * 'new_relmin_mxid' arguments are required when freezing. When * HEAP_PAGE_PRUNE_FREEZE option is passed, we also set presult->all_visible * and presult->all_frozen after determining whether or not to - * opporunistically freeze, to indicate if the VM bits can be set. They are + * opportunistically freeze, to indicate if the VM bits can be set. They are * always set to false when the HEAP_PAGE_PRUNE_FREEZE option is not passed, * because at the moment only callers that also freeze need that information. * @@ -504,6 +504,9 @@ heap_page_prune_and_freeze(PruneFreezeParams *params, prstate.vistest = params->vistest; prstate.mark_unused_now = (params->options & HEAP_PAGE_PRUNE_MARK_UNUSED_NOW) != 0; + + /* cutoffs must be provided if we will attempt freezing */ + Assert(!(params->options & HEAP_PAGE_PRUNE_FREEZE) || params->cutoffs); prstate.attempt_freeze = (params->options & HEAP_PAGE_PRUNE_FREEZE) != 0; prstate.cutoffs = params->cutoffs; -- cgit v1.2.3