From 342bb38bfeb099c5f8aa8f44a7e18f2dc21f1ecd Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Wed, 19 Oct 2022 12:35:00 +0200 Subject: Get rid of XLogCtlInsert->forcePageWrites After commit 39969e2a1e4d, ->forcePageWrites is no longer very interesting: we can just test whether runningBackups is different from 0. This simplifies some code, so do away with it. Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/39969e2a1e4d7f5a37f3ef37d53bbfe171e7d77a --- src/backend/access/transam/xloginsert.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/backend/access/transam/xloginsert.c') diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 5ca15ebbf20..f8115234484 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -973,9 +973,9 @@ XLogCompressBackupBlock(char *page, uint16 hole_offset, uint16 hole_length, /* * Determine whether the buffer referenced has to be backed up. * - * Since we don't yet have the insert lock, fullPageWrites and forcePageWrites - * could change later, so the result should be used for optimization purposes - * only. + * Since we don't yet have the insert lock, fullPageWrites and runningBackups + * (which forces full-page writes) could change later, so the result should + * be used for optimization purposes only. */ bool XLogCheckBufferNeedsBackup(Buffer buffer) -- cgit v1.2.3