From c1d1ae1db23796e4d1b04f5c087944722cf1446a Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 21 Sep 2021 19:47:53 -0300 Subject: Document XLOG_INCLUDE_XID a little better MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I noticed that commit 0bead9af484c left this flag undocumented in XLogSetRecordFlags, which led me to discover that the flag doesn't actually do what the one comment on it said it does. Improve the situation by adding some more comments. Backpatch to 14, where the aforementioned commit appears. Author: Álvaro Herrera Discussion: https://postgr.es/m/202109212119.c3nhfp64t2ql@alvherre.pgsql --- src/backend/access/transam/xloginsert.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/backend/access/transam/xloginsert.c') diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 32b4cc84e79..b153fad594d 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -399,6 +399,8 @@ XLogRegisterBufData(uint8 block_id, char *data, int len) * - XLOG_MARK_UNIMPORTANT, to signal that the record is not important for * durability, which allows to avoid triggering WAL archiving and other * background activity. + * - XLOG_INCLUDE_XID, a message-passing hack between XLogRecordAssemble + * and XLogResetInsertion. */ void XLogSetRecordFlags(uint8 flags) -- cgit v1.2.3