From af1a949109d8212711df943c053b1038c0afdae1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 9 Apr 2018 14:39:58 -0400 Subject: Further cleanup of client dependencies on src/include/catalog headers. In commit 9c0a0de4c, I'd failed to notice that catalog/catalog.h should also be considered a frontend-unsafe header, because it includes (and needs) the full form of pg_class.h, not to mention relcache.h. However, various frontend code was depending on it to get TABLESPACE_VERSION_DIRECTORY, so refactoring of some sort is called for. The cleanest answer seems to be to move TABLESPACE_VERSION_DIRECTORY, as well as the OIDCHARS symbol, to common/relpath.h. Do that, and mop up inclusions as necessary. (I found that quite a few current users of catalog/catalog.h don't seem to need it at all anymore, apparently as a result of the refactorings that created common/relpath.[hc]. And initdb.c needed it only as a route to pg_class_d.h.) Discussion: https://postgr.es/m/6629.1523294509@sss.pgh.pa.us --- src/backend/access/transam/xlogutils.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/backend/access/transam/xlogutils.c') diff --git a/src/backend/access/transam/xlogutils.c b/src/backend/access/transam/xlogutils.c index 89da25c207c..52fe55e2afb 100644 --- a/src/backend/access/transam/xlogutils.c +++ b/src/backend/access/transam/xlogutils.c @@ -23,7 +23,6 @@ #include "access/xlog.h" #include "access/xlog_internal.h" #include "access/xlogutils.h" -#include "catalog/catalog.h" #include "miscadmin.h" #include "pgstat.h" #include "storage/smgr.h" -- cgit v1.2.3