From bf56f0759bdfa87f143c3abd09f893a5f530fe88 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 10 Aug 2001 18:57:42 +0000 Subject: Make OIDs optional, per discussions in pghackers. WITH OIDS is still the default, but OIDS are removed from many system catalogs that don't need them. Some interesting side effects: TOAST pointers are 20 bytes not 32 now; pg_description has a three-column key instead of one. Bugs fixed in passing: BINARY cursors work again; pg_class.relhaspkey has some usefulness; pg_dump dumps comments on indexes, rules, and triggers in a valid order. initdb forced. --- src/backend/bootstrap/bootstrap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/backend/bootstrap/bootstrap.c') diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c index 56009217090..1bb561f40c6 100644 --- a/src/backend/bootstrap/bootstrap.c +++ b/src/backend/bootstrap/bootstrap.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/bootstrap/bootstrap.c,v 1.113 2001/08/04 00:14:43 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/bootstrap/bootstrap.c,v 1.114 2001/08/10 18:57:33 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -627,7 +627,9 @@ DefineAttr(char *name, char *type, int attnum) /* ---------------- * InsertOneTuple - * assumes that 'oid' will not be zero. + * + * If objectid is not zero, it is a specific OID to assign to the tuple. + * Otherwise, an OID will be assigned (if necessary) by heap_insert. * ---------------- */ void @@ -635,7 +637,6 @@ InsertOneTuple(Oid objectid) { HeapTuple tuple; TupleDesc tupDesc; - int i; if (DebugMode) @@ -664,7 +665,7 @@ InsertOneTuple(Oid objectid) * ---------------- */ void -InsertOneValue(Oid objectid, char *value, int i) +InsertOneValue(char *value, int i) { int typeindex; char *prt; -- cgit v1.2.3