From a236dd9536bd4624b259759e08cb2b8d4585ab0f Mon Sep 17 00:00:00 2001
From: Neil Conway <neilc@samurai.com>
Date: Sun, 14 Nov 2004 02:04:14 +0000
Subject: There is no need for ReadBuffer() call sites to check that the
 returned buffer is valid, as ReadBuffer() will elog on error. Most of the
 call sites of ReadBuffer() got this right, but this patch fixes those call
 sites that did not.

---
 src/backend/commands/analyze.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'src/backend/commands/analyze.c')

diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 872edc42988..3157d1dfd6f 100644
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.78 2004/10/26 16:05:03 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.79 2004/11/14 02:04:13 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -811,8 +811,6 @@ acquire_sample_rows(Relation onerel, HeapTuple *rows, int targrows,
 		 * tuples.
 		 */
 		targbuffer = ReadBuffer(onerel, targblock);
-		if (!BufferIsValid(targbuffer))
-			elog(ERROR, "ReadBuffer failed");
 		LockBuffer(targbuffer, BUFFER_LOCK_SHARE);
 		targpage = BufferGetPage(targbuffer);
 		maxoffset = PageGetMaxOffsetNumber(targpage);
-- 
cgit v1.2.3