From 92af9143f13df8c54362ebbd4397cb53f207ff2d Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 12 Aug 2022 12:05:50 +0200 Subject: Reject MERGE in CTEs and COPY The grammar added for MERGE inadvertently made it accepted syntax in places that were not prepared to deal with it -- namely COPY and inside CTEs, but invoking these things with MERGE currently causes assertion failures or weird misbehavior in non-assertion builds. Protect those places by checking for it explicitly until somebody decides to implement it. Reported-by: Alexey Borzov Discussion: https://postgr.es/m/17579-82482cd7b267b862@postgresql.org --- src/backend/commands/copy.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/backend/commands/copy.c') diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 3ac731803bd..49924e476af 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -273,6 +273,12 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt, { Assert(stmt->query); + /* MERGE is allowed by parser, but unimplemented. Reject for now */ + if (IsA(stmt->query, MergeStmt)) + ereport(ERROR, + errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("MERGE not supported in COPY")); + query = makeNode(RawStmt); query->stmt = stmt->query; query->stmt_location = stmt_location; -- cgit v1.2.3