From b1484a3f1910bfd0e254afe40085dfc3351bda8c Mon Sep 17 00:00:00 2001 From: Alexander Korotkov Date: Sat, 30 Mar 2024 22:39:03 +0200 Subject: Let table AM insertion methods control index insertion Previously, the executor did index insert unconditionally after calling table AM interface methods tuple_insert() and multi_insert(). This commit introduces the new parameter insert_indexes for these two methods. Setting '*insert_indexes' to true saves the current logic. Setting it to false indicates that table AM cares about index inserts itself and doesn't want the caller to do that. Discussion: https://postgr.es/m/CAPpHfdurb9ycV8udYqM%3Do0sPS66PJ4RCBM1g-bBpvzUfogY0EA%40mail.gmail.com Reviewed-by: Pavel Borisov, Matthias van de Meent, Mark Dilger --- src/backend/commands/createas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/backend/commands/createas.c') diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c index 62050f4dc59..afd3dace079 100644 --- a/src/backend/commands/createas.c +++ b/src/backend/commands/createas.c @@ -578,6 +578,7 @@ static bool intorel_receive(TupleTableSlot *slot, DestReceiver *self) { DR_intorel *myState = (DR_intorel *) self; + bool insertIndexes; /* Nothing to insert if WITH NO DATA is specified. */ if (!myState->into->skipData) @@ -594,7 +595,8 @@ intorel_receive(TupleTableSlot *slot, DestReceiver *self) slot, myState->output_cid, myState->ti_options, - myState->bistate); + myState->bistate, + &insertIndexes); } /* We know this is a newly created relation, so there are no indexes */ -- cgit v1.2.3