From a89505fd21da337b81172871d8f65d9a4fa22a8b Mon Sep 17 00:00:00 2001 From: Stephen Frost Date: Fri, 6 May 2016 14:06:50 -0400 Subject: Remove various special checks around default roles Default roles really should be like regular roles, for the most part. This removes a number of checks that were trying to make default roles extra special by not allowing them to be used as regular roles. We still prevent users from creating roles in the "pg_" namespace or from altering roles which exist in that namespace via ALTER ROLE, as we can't preserve such changes, but otherwise the roles are very much like regular roles. Based on discussion with Robert and Tom. --- src/backend/commands/foreigncmds.c | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'src/backend/commands/foreigncmds.c') diff --git a/src/backend/commands/foreigncmds.c b/src/backend/commands/foreigncmds.c index 88cefb7f958..804bab2e1f5 100644 --- a/src/backend/commands/foreigncmds.c +++ b/src/backend/commands/foreigncmds.c @@ -1148,10 +1148,6 @@ CreateUserMapping(CreateUserMappingStmt *stmt) else useId = get_rolespec_oid(stmt->user, false); - /* Additional check to protect reserved role names */ - check_rolespec_name(stmt->user, - "Cannot specify reserved role as mapping user."); - /* Check that the server exists. */ srv = GetForeignServerByName(stmt->servername, false); @@ -1252,10 +1248,6 @@ AlterUserMapping(AlterUserMappingStmt *stmt) else useId = get_rolespec_oid(stmt->user, false); - /* Additional check to protect reserved role names */ - check_rolespec_name(stmt->user, - "Cannot alter reserved role mapping user."); - srv = GetForeignServerByName(stmt->servername, false); umId = GetSysCacheOid2(USERMAPPINGUSERSERVER, @@ -1345,11 +1337,6 @@ RemoveUserMapping(DropUserMappingStmt *stmt) else { useId = get_rolespec_oid(stmt->user, stmt->missing_ok); - - /* Additional check to protect reserved role names */ - check_rolespec_name(stmt->user, - "Cannot remove reserved role mapping user."); - if (!OidIsValid(useId)) { /* -- cgit v1.2.3