From 61ae9d6bc763599a01424c7967d7b034ba7f792e Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 27 Oct 2020 13:49:19 -0300 Subject: Accept relations of any kind in LOCK TABLE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The restriction that only tables and views can be locked by LOCK TABLE is quite arbitrary, since the underlying mechanism can lock any relation type. Drop the restriction so that programs such as pg_dump can lock all relations they're interested in, preventing schema changes that could cause a dump to fail after expending much effort. Backpatch to 9.5. Author: Álvaro Herrera Reviewed-by: Tom Lane Reported-by: Wells Oliver Discussion: https://postgr.es/m/20201021200659.GA32358@alvherre.pgsql --- src/backend/commands/lockcmds.c | 7 ------- 1 file changed, 7 deletions(-) (limited to 'src/backend/commands/lockcmds.c') diff --git a/src/backend/commands/lockcmds.c b/src/backend/commands/lockcmds.c index a1670821aa4..15b4c2f90ad 100644 --- a/src/backend/commands/lockcmds.c +++ b/src/backend/commands/lockcmds.c @@ -87,13 +87,6 @@ RangeVarCallbackForLockTable(const RangeVar *rv, Oid relid, Oid oldrelid, return; /* woops, concurrently dropped; no permissions * check */ - /* Currently, we only allow plain tables to be locked */ - if (relkind != RELKIND_RELATION) - ereport(ERROR, - (errcode(ERRCODE_WRONG_OBJECT_TYPE), - errmsg("\"%s\" is not a table", - rv->relname))); - /* Check permissions. */ aclresult = LockTableAclCheck(relid, lockmode); if (aclresult != ACLCHECK_OK) -- cgit v1.2.3