From a236dd9536bd4624b259759e08cb2b8d4585ab0f Mon Sep 17 00:00:00 2001
From: Neil Conway <neilc@samurai.com>
Date: Sun, 14 Nov 2004 02:04:14 +0000
Subject: There is no need for ReadBuffer() call sites to check that the
 returned buffer is valid, as ReadBuffer() will elog on error. Most of the
 call sites of ReadBuffer() got this right, but this patch fixes those call
 sites that did not.

---
 src/backend/commands/sequence.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

(limited to 'src/backend/commands/sequence.c')

diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c
index de71560d1da..98763cf0b2c 100644
--- a/src/backend/commands/sequence.c
+++ b/src/backend/commands/sequence.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.117 2004/09/16 16:58:28 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.118 2004/11/14 02:04:14 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -192,10 +192,6 @@ DefineSequence(CreateSeqStmt *seq)
 	/* Initialize first page of relation with special magic number */
 
 	buf = ReadBuffer(rel, P_NEW);
-
-	if (!BufferIsValid(buf))
-		elog(ERROR, "ReadBuffer failed");
-
 	Assert(BufferGetBlockNumber(buf) == 0);
 
 	page = (PageHeader) BufferGetPage(buf);
@@ -850,9 +846,6 @@ read_info(SeqTable elm, Relation rel, Buffer *buf)
 	Form_pg_sequence seq;
 
 	*buf = ReadBuffer(rel, 0);
-	if (!BufferIsValid(*buf))
-		elog(ERROR, "ReadBuffer failed");
-
 	LockBuffer(*buf, BUFFER_LOCK_EXCLUSIVE);
 
 	page = (PageHeader) BufferGetPage(*buf);
-- 
cgit v1.2.3