From 4b4ee1e2b073ffe719e7ad1bb1c22253fb1096e2 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Wed, 21 Jun 2023 10:07:47 +0530 Subject: Fix the errhint message and docs for drop subscription failure. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The existing errhint message and docs were missing the fact that we can't disassociate from the slot unless the subscription is disabled. Author: Robert Sjöblom, Peter Smith Reviewed-by: Peter Eisentraut, Amit Kapila Backpatch-through: 11 Discussion: https://postgr.es/m/807bdf85-61ea-88e2-5712-6d9fcd4eabff@fortnox.se --- src/backend/commands/subscriptioncmds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/backend/commands/subscriptioncmds.c') diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index c99c943a206..40356e97ed2 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -992,7 +992,8 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel) "drop the replication slot \"%s\"", slotname), errdetail("The error was: %s", err), /* translator: %s is an SQL ALTER command */ - errhint("Use %s to disassociate the subscription from the slot.", + errhint("Use %s to disable the subscription, and then use %s to disassociate it from the slot.", + "ALTER SUBSCRIPTION ... DISABLE", "ALTER SUBSCRIPTION ... SET (slot_name = NONE)"))); PG_TRY(); -- cgit v1.2.3