From 503e3833ef240c94e114be8703046d52f24da021 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 13 Jul 2022 11:40:00 +0200 Subject: Remove useless assertions We don't need Assert(IsA(foo, String)) right before running strVal(foo), since strVal() already does the assertion internally (via castNode()). --- src/backend/commands/tablecmds.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/backend/commands/tablecmds.c') diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index ef5b34a3126..701bd73f5ee 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -8271,7 +8271,6 @@ ATExecSetStorage(Relation rel, const char *colName, Node *newValue, LOCKMODE loc AttrNumber attnum; ObjectAddress address; - Assert(IsA(newValue, String)); storagemode = strVal(newValue); if (pg_strcasecmp(storagemode, "plain") == 0) @@ -16171,7 +16170,6 @@ ATExecSetCompression(AlteredTableInfo *tab, char cmethod; ObjectAddress address; - Assert(IsA(newValue, String)); compression = strVal(newValue); attrel = table_open(AttributeRelationId, RowExclusiveLock); -- cgit v1.2.3