From 1f29a1d2288a10282fa0dc4cd53000f4d660c7d6 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 17 Feb 2019 12:37:32 -0500 Subject: Fix CREATE VIEW to allow zero-column views. We should logically have allowed this case when we allowed zero-column tables, but it was overlooked. Although this might be thought a feature addition, it's really a bug fix, because it was possible to create a zero-column view via the convert-table-to-view code path, and then you'd have a situation where dump/reload would fail. Hence, back-patch to all supported branches. Arrange the added test cases to provide coverage of the related pg_dump code paths (since these views will be dumped and reloaded during the pg_upgrade regression test). I also made them test the case where pg_dump has to postpone the view rule into post-data, which disturbingly had no regression coverage before. Report and patch by Ashutosh Sharma (test case by me) Discussion: https://postgr.es/m/CAE9k0PkmHdeSaeZt2ujnb_cKucmK3sDDceDzw7+d5UZoNJPYOg@mail.gmail.com --- src/backend/commands/view.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/backend/commands/view.c') diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c index 67046752d30..ec0c90b42a2 100644 --- a/src/backend/commands/view.c +++ b/src/backend/commands/view.c @@ -111,11 +111,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace, } } - if (attrList == NIL) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TABLE_DEFINITION), - errmsg("view must have at least one column"))); - /* * Look up, check permissions on, and lock the creation namespace; also * check for a preexisting view with the same name. This will also set -- cgit v1.2.3