From 3e9744465dbe51822c7d76baca1f934d54ba9452 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 12 May 2020 16:01:52 -0400 Subject: Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use it at level 4, a bit more restrictive than the default level, and tweak our commanding comments to FALLTHROUGH. (However, leave zic.c alone, since it's external code; to avoid the warnings that would appear there, change CFLAGS for that file in the Makefile.) Author: Julien Rouhaud Author: Álvaro Herrera Reviewed-by: Tom Lane Discussion: https://postgr.es/m/20200412081825.qyo5vwwco3fv4gdo@nol Discussion: https://postgr.es/m/flat/E1fDenm-0000C8-IJ@gemulon.postgresql.org --- src/backend/executor/nodeLimit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/executor/nodeLimit.c') diff --git a/src/backend/executor/nodeLimit.c b/src/backend/executor/nodeLimit.c index d85cf7d93e8..371b15c14a7 100644 --- a/src/backend/executor/nodeLimit.c +++ b/src/backend/executor/nodeLimit.c @@ -69,7 +69,7 @@ ExecLimit(PlanState *pstate) */ recompute_limits(node); - /* FALL THRU */ + /* FALLTHROUGH */ case LIMIT_RESCAN: @@ -216,7 +216,7 @@ ExecLimit(PlanState *pstate) } Assert(node->lstate == LIMIT_WINDOWEND_TIES); - /* FALL THRU */ + /* FALLTHROUGH */ case LIMIT_WINDOWEND_TIES: if (ScanDirectionIsForward(direction)) -- cgit v1.2.3