From e0a2721f7c169b50617fed797d7336cd8f10bf77 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 19 Dec 2024 18:07:00 -0500 Subject: Get rid of old version of BuildTupleHashTable(). It was reasonable to preserve the old API of BuildTupleHashTable() in the back branches, but in HEAD we should actively discourage use of that version. There are no remaining callers in core, so just get rid of it. Then rename BuildTupleHashTableExt() back to BuildTupleHashTable(). While at it, fix up the miserably-poorly-maintained header comment for BuildTupleHashTable[Ext]. It looks like more than one patch in this area has had the opinion that updating comments is beneath them. Discussion: https://postgr.es/m/538343.1734646986@sss.pgh.pa.us --- src/backend/executor/nodeSubplan.c | 58 +++++++++++++++++++------------------- 1 file changed, 29 insertions(+), 29 deletions(-) (limited to 'src/backend/executor/nodeSubplan.c') diff --git a/src/backend/executor/nodeSubplan.c b/src/backend/executor/nodeSubplan.c index bb4a0219194..316995ca9f7 100644 --- a/src/backend/executor/nodeSubplan.c +++ b/src/backend/executor/nodeSubplan.c @@ -523,7 +523,7 @@ buildSubPlanHash(SubPlanState *node, ExprContext *econtext) * Because the input slot for each hash table is always the slot resulting * from an ExecProject(), we can use TTSOpsVirtual for the input ops. This * saves a needless fetch inner op step for the hashing ExprState created - * in BuildTupleHashTableExt(). + * in BuildTupleHashTable(). */ MemoryContextReset(node->hashtablecxt); node->havehashrows = false; @@ -536,20 +536,20 @@ buildSubPlanHash(SubPlanState *node, ExprContext *econtext) if (node->hashtable) ResetTupleHashTable(node->hashtable); else - node->hashtable = BuildTupleHashTableExt(node->parent, - node->descRight, - &TTSOpsVirtual, - ncols, - node->keyColIdx, - node->tab_eq_funcoids, - node->tab_hash_funcs, - node->tab_collations, - nbuckets, - 0, - node->planstate->state->es_query_cxt, - node->hashtablecxt, - node->hashtempcxt, - false); + node->hashtable = BuildTupleHashTable(node->parent, + node->descRight, + &TTSOpsVirtual, + ncols, + node->keyColIdx, + node->tab_eq_funcoids, + node->tab_hash_funcs, + node->tab_collations, + nbuckets, + 0, + node->planstate->state->es_query_cxt, + node->hashtablecxt, + node->hashtempcxt, + false); if (!subplan->unknownEqFalse) { @@ -565,20 +565,20 @@ buildSubPlanHash(SubPlanState *node, ExprContext *econtext) if (node->hashnulls) ResetTupleHashTable(node->hashnulls); else - node->hashnulls = BuildTupleHashTableExt(node->parent, - node->descRight, - &TTSOpsVirtual, - ncols, - node->keyColIdx, - node->tab_eq_funcoids, - node->tab_hash_funcs, - node->tab_collations, - nbuckets, - 0, - node->planstate->state->es_query_cxt, - node->hashtablecxt, - node->hashtempcxt, - false); + node->hashnulls = BuildTupleHashTable(node->parent, + node->descRight, + &TTSOpsVirtual, + ncols, + node->keyColIdx, + node->tab_eq_funcoids, + node->tab_hash_funcs, + node->tab_collations, + nbuckets, + 0, + node->planstate->state->es_query_cxt, + node->hashtablecxt, + node->hashtempcxt, + false); } else node->hashnulls = NULL; -- cgit v1.2.3