From 5e1f3b9ebf6e51f2c60abe9aba969c28a3b0f6c6 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 13 Nov 2022 10:22:45 -0500 Subject: Make Bitmapsets be valid Nodes. Add a NodeTag field to struct Bitmapset. This is free because of alignment considerations on 64-bit hardware. While it adds some space on 32-bit machines, we aren't optimizing for that case anymore. The advantage is that data structures such as Lists of Bitmapsets are now first-class objects to the Node infrastructure, and don't require special-case code to handle. This patch includes removal of one such special case, in indxpath.c: bms_equal_any() can now be replaced by list_member(). There may be more existing code that could be simplified, but I didn't look very hard. We also get to drop the read_write_ignore annotations on a couple of RelOptInfo fields. The outfuncs/readfuncs support is arranged so that nothing changes in the string representation of a Bitmapset field; therefore, this doesn't need a catversion bump. Amit Langote and Tom Lane Discussion: https://postgr.es/m/109089.1668197158@sss.pgh.pa.us --- src/backend/nodes/equalfuncs.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/backend/nodes/equalfuncs.c') diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c index 0373aa30fe9..b2f07da62e0 100644 --- a/src/backend/nodes/equalfuncs.c +++ b/src/backend/nodes/equalfuncs.c @@ -145,6 +145,12 @@ _equalA_Const(const A_Const *a, const A_Const *b) return true; } +static bool +_equalBitmapset(const Bitmapset *a, const Bitmapset *b) +{ + return bms_equal(a, b); +} + /* * Lists are handled specially */ -- cgit v1.2.3