From e549722a8b2fcc5b2ad9a9bd53948466ea5dae26 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 25 Feb 2009 03:30:38 +0000 Subject: Get rid of the rather fuzzily defined FlattenedSubLink node type in favor of making pull_up_sublinks() construct a full-blown JoinExpr tree representation of IN/EXISTS SubLinks that it is able to convert to semi or anti joins. This makes pull_up_sublinks() a shade more complex, but the gain in semantic clarity is worth it. I still have more to do in this area to address the previously-discussed problems, but this commit in itself fixes at least one bug in HEAD, as shown by added regression test case. --- src/backend/nodes/nodeFuncs.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) (limited to 'src/backend/nodes/nodeFuncs.c') diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c index 683436f17ba..8a04d71eb82 100644 --- a/src/backend/nodes/nodeFuncs.c +++ b/src/backend/nodes/nodeFuncs.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/nodeFuncs.c,v 1.37 2009/01/01 17:23:43 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/nodeFuncs.c,v 1.38 2009/02/25 03:30:37 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1309,14 +1309,6 @@ expression_tree_walker(Node *node, /* groupClauses are deemed uninteresting */ } break; - case T_FlattenedSubLink: - { - FlattenedSubLink *fslink = (FlattenedSubLink *) node; - - if (walker(fslink->quals, context)) - return true; - } - break; case T_PlaceHolderVar: return walker(((PlaceHolderVar *) node)->phexpr, context); case T_AppendRelInfo: @@ -1972,17 +1964,6 @@ expression_tree_mutator(Node *node, return (Node *) newnode; } break; - case T_FlattenedSubLink: - { - FlattenedSubLink *fslink = (FlattenedSubLink *) node; - FlattenedSubLink *newnode; - - FLATCOPY(newnode, fslink, FlattenedSubLink); - /* Assume we need not copy the relids bitmapsets */ - MUTATE(newnode->quals, fslink->quals, Expr *); - return (Node *) newnode; - } - break; case T_PlaceHolderVar: { PlaceHolderVar *phv = (PlaceHolderVar *) node; -- cgit v1.2.3