From 12b1b5d837b5ce1c07ee3535e74e4cc3039063d6 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 11 Dec 2004 23:26:51 +0000 Subject: Instead of supposing (wrongly, in the general case) that the rowtype of an inheritance child table is binary-compatible with the rowtype of its parent, invent an expression node type that does the conversion correctly. Fixes the new bug exhibited by Kris Shannon as well as a lot of old bugs that would only show up when using multiple inheritance or after altering the parent table. --- src/backend/optimizer/prep/prepjointree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'src/backend/optimizer/prep/prepjointree.c') diff --git a/src/backend/optimizer/prep/prepjointree.c b/src/backend/optimizer/prep/prepjointree.c index af53c4592cc..cd461d237f3 100644 --- a/src/backend/optimizer/prep/prepjointree.c +++ b/src/backend/optimizer/prep/prepjointree.c @@ -16,7 +16,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/optimizer/prep/prepjointree.c,v 1.23 2004/08/29 05:06:44 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/optimizer/prep/prepjointree.c,v 1.24 2004/12/11 23:26:37 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -839,6 +839,13 @@ find_nonnullable_rels(Node *node, bool top_level) result = find_nonnullable_rels((Node *) expr->arg, top_level); } + else if (IsA(node, ConvertRowtypeExpr)) + { + /* not clear this is useful, but it can't hurt */ + ConvertRowtypeExpr *expr = (ConvertRowtypeExpr *) node; + + result = find_nonnullable_rels((Node *) expr->arg, top_level); + } else if (IsA(node, NullTest)) { NullTest *expr = (NullTest *) node; -- cgit v1.2.3