From aebeb4790c750dc808c1c5afb3cb435116244e36 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 25 Jan 2017 09:33:41 -0500 Subject: Remove vestigial resolveUnknown arguments from transformSortClause etc. There's really no situation where we don't want these unknown-to-text conversions to happen. The alternative is failure anyway, and the one caller that was passing "false" did so only because it expected the case could not arise. Might as well simplify the code. Discussion: https://postgr.es/m/CAH2L28uwwbL9HUM-WR=hromW1Cvamkn7O-g8fPY2m=_7muJ0oA@mail.gmail.com --- src/backend/parser/parse_agg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/backend/parser/parse_agg.c') diff --git a/src/backend/parser/parse_agg.c b/src/backend/parser/parse_agg.c index 7be7fe96892..efe1c371efc 100644 --- a/src/backend/parser/parse_agg.c +++ b/src/backend/parser/parse_agg.c @@ -155,8 +155,7 @@ transformAggregateCall(ParseState *pstate, Aggref *agg, tlist = lappend(tlist, tle); torder = addTargetToSortList(pstate, tle, - torder, tlist, sortby, - true /* fix unknowns */ ); + torder, tlist, sortby); } /* Never any DISTINCT in an ordered-set agg */ @@ -196,7 +195,6 @@ transformAggregateCall(ParseState *pstate, Aggref *agg, aggorder, &tlist, EXPR_KIND_ORDER_BY, - true /* fix unknowns */ , true /* force SQL99 rules */ ); /* -- cgit v1.2.3