From 052cc223d5ce1b727f62afff75797c88d82f880b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 30 Aug 2016 18:22:43 -0400 Subject: Fix a bunch of places that called malloc and friends with no NULL check. Where possible, use palloc or pg_malloc instead; otherwise, insert explicit NULL checks. Generally speaking, these are places where an actual OOM is quite unlikely, either because they're in client programs that don't allocate all that much, or they're very early in process startup so that we'd likely have had a fork() failure instead. Hence, no back-patch, even though this is nominally a bug fix. Michael Paquier, with some adjustments by me Discussion: --- src/backend/port/dynloader/darwin.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/backend/port/dynloader/darwin.c') diff --git a/src/backend/port/dynloader/darwin.c b/src/backend/port/dynloader/darwin.c index ccd92c39d4b..a83c614f4f1 100644 --- a/src/backend/port/dynloader/darwin.c +++ b/src/backend/port/dynloader/darwin.c @@ -78,6 +78,9 @@ pg_dlsym(void *handle, char *funcname) NSSymbol symbol; char *symname = (char *) malloc(strlen(funcname) + 2); + if (!symname) + return NULL; + sprintf(symname, "_%s", funcname); if (NSIsSymbolNameDefined(symname)) { -- cgit v1.2.3