From 654b702a1c01fa047a363a887f957886503ea67c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 3 Jul 2013 12:26:33 -0400 Subject: Fix handling of auto-updatable views on inherited tables. An INSERT into such a view should work just like an INSERT into its base table, ie the insertion should go directly into that table ... not be duplicated into each child table, as was happening before, per bug #8275 from Rushabh Lathia. On the other hand, the current behavior for UPDATE/DELETE seems reasonable: the update/delete traverses the child tables, or not, depending on whether the view specifies ONLY or not. Add some regression tests covering this area. Dean Rasheed --- src/backend/rewrite/rewriteHandler.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/backend/rewrite/rewriteHandler.c') diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c index a467588e50e..4163301542a 100644 --- a/src/backend/rewrite/rewriteHandler.c +++ b/src/backend/rewrite/rewriteHandler.c @@ -2388,6 +2388,13 @@ rewriteTargetView(Query *parsetree, Relation view) parsetree->rtable = lappend(parsetree->rtable, new_rte); new_rt_index = list_length(parsetree->rtable); + /* + * INSERTs never inherit. For UPDATE/DELETE, we use the view query's + * inheritance flag for the base relation. + */ + if (parsetree->commandType == CMD_INSERT) + new_rte->inh = false; + /* * Make a copy of the view's targetlist, adjusting its Vars to reference * the new target RTE, ie make their varnos be new_rt_index instead of -- cgit v1.2.3