From e68b6adad96d414fdf24e072fdb1d41fb4b8f0b7 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Fri, 28 Nov 2025 05:21:35 +0000 Subject: Add slotsync_skip_reason column to pg_replication_slots view. Introduce a new column, slotsync_skip_reason, in the pg_replication_slots view. This column records the reason why the last slot synchronization was skipped. It is primarily relevant for logical replication slots on standby servers where the 'synced' field is true. The value is NULL when synchronization succeeds. Author: Shlok Kyal Reviewed-by: shveta malik Reviewed-by: Hayato Kuroda Reviewed-by: Ashutosh Sharma Reviewed-by: Hou Zhijie Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAE9k0PkhfKrTEAsGz4DjOhEj1nQ+hbQVfvWUxNacD38ibW3a1g@mail.gmail.com --- src/backend/utils/activity/pgstat_replslot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/utils/activity/pgstat_replslot.c') diff --git a/src/backend/utils/activity/pgstat_replslot.c b/src/backend/utils/activity/pgstat_replslot.c index f93179146c2..e08d33e8b4c 100644 --- a/src/backend/utils/activity/pgstat_replslot.c +++ b/src/backend/utils/activity/pgstat_replslot.c @@ -115,8 +115,8 @@ pgstat_report_replslotsync(ReplicationSlot *slot) PgStatShared_ReplSlot *shstatent; PgStat_StatReplSlotEntry *statent; - /* Slot sync stats are valid only for logical slots on standby. */ - Assert(SlotIsLogical(slot)); + /* Slot sync stats are valid only for synced logical slots on standby. */ + Assert(slot->data.synced); Assert(RecoveryInProgress()); entry_ref = pgstat_get_entry_ref_locked(PGSTAT_KIND_REPLSLOT, InvalidOid, -- cgit v1.2.3