From 7f798aca1d5df290aafad41180baea0ae311b4ee Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 28 Nov 2024 08:19:22 +0100 Subject: Remove useless casts to (void *) Many of them just seem to have been copied around for no real reason. Their presence causes (small) risks of hiding actual type mismatches or silently discarding qualifiers Discussion: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org --- src/backend/utils/adt/array_userfuncs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/backend/utils/adt/array_userfuncs.c') diff --git a/src/backend/utils/adt/array_userfuncs.c b/src/backend/utils/adt/array_userfuncs.c index d053808f6ee..304a93112e2 100644 --- a/src/backend/utils/adt/array_userfuncs.c +++ b/src/backend/utils/adt/array_userfuncs.c @@ -685,7 +685,7 @@ array_agg_serialize(PG_FUNCTION_ARGS) &typisvarlena); fmgr_info_cxt(typsend, &iodata->typsend, fcinfo->flinfo->fn_mcxt); - fcinfo->flinfo->fn_extra = (void *) iodata; + fcinfo->flinfo->fn_extra = iodata; } for (i = 0; i < state->nelems; i++) @@ -776,7 +776,7 @@ array_agg_deserialize(PG_FUNCTION_ARGS) &iodata->typioparam); fmgr_info_cxt(typreceive, &iodata->typreceive, fcinfo->flinfo->fn_mcxt); - fcinfo->flinfo->fn_extra = (void *) iodata; + fcinfo->flinfo->fn_extra = iodata; } for (int i = 0; i < nelems; i++) @@ -1642,7 +1642,7 @@ array_shuffle(PG_FUNCTION_ARGS) if (typentry == NULL || typentry->type_id != elmtyp) { typentry = lookup_type_cache(elmtyp, 0); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } result = array_shuffle_n(array, ARR_DIMS(array)[0], true, elmtyp, typentry); @@ -1678,7 +1678,7 @@ array_sample(PG_FUNCTION_ARGS) if (typentry == NULL || typentry->type_id != elmtyp) { typentry = lookup_type_cache(elmtyp, 0); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } result = array_shuffle_n(array, n, false, elmtyp, typentry); -- cgit v1.2.3