From 91e7c903291116bd081abe7d4a058d40a2a06e16 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 1 Apr 2021 16:12:53 +0200 Subject: Fix internal extract(timezone_minute) formulas Through various refactorings over time, the extract(timezone_minute from time with time zone) and extract(timezone_minute from timestamp with time zone) implementations ended up with two different but equally nonsensical formulas by using SECS_PER_MINUTE and MINS_PER_HOUR interchangeably. Since those two are of course both the same number, the formulas do work, but for readability, fix them to be semantically correct. --- src/backend/utils/adt/timestamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/backend/utils/adt/timestamp.c') diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c index f619b56d6f5..194861f19e3 100644 --- a/src/backend/utils/adt/timestamp.c +++ b/src/backend/utils/adt/timestamp.c @@ -4844,7 +4844,7 @@ timestamptz_part(PG_FUNCTION_ARGS) case DTK_TZ_MINUTE: result = -tz; - result /= MINS_PER_HOUR; + result /= SECS_PER_MINUTE; FMODULO(result, dummy, (double) MINS_PER_HOUR); break; -- cgit v1.2.3