From 6e07228728e51bf875ecc9669f63ed648aba88c9 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 19 Jun 2007 20:13:22 +0000 Subject: Code review for log_lock_waits patch. Don't try to issue log messages from within a signal handler (this might be safe given the relatively narrow code range in which the interrupt is enabled, but it seems awfully risky); do issue more informative log messages that tell what is being waited for and the exact length of the wait; minor other code cleanup. Greg Stark and Tom Lane --- src/backend/utils/misc/guc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/backend/utils/misc/guc.c') diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index f801c060d78..c1e9d8e7213 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut . * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.398 2007/06/18 10:02:57 mha Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.399 2007/06/19 20:13:22 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -825,13 +825,14 @@ static struct config_bool ConfigureNamesBool[] = #endif { - {"log_lock_waits", PGC_SIGHUP, LOGGING_WHAT, - gettext_noop("Logs long lock wait events."), + {"log_lock_waits", PGC_SUSET, LOGGING_WHAT, + gettext_noop("Logs long lock waits."), NULL }, &log_lock_waits, false, NULL, NULL }, + { {"log_hostname", PGC_SIGHUP, LOGGING_WHAT, gettext_noop("Logs the host name in the connection logs."), -- cgit v1.2.3