From 901be0fad4034c9cf8a3588fd6cf2ece82e4b8ce Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 7 Jan 2010 04:53:35 +0000 Subject: Remove all the special-case code for INT64_IS_BUSTED, per decision that we're not going to support that anymore. I did keep the 64-bit-CRC-with-32-bit-arithmetic code, since it has a performance excuse to live. It's a bit moot since that's all ifdef'd out, of course. --- src/backend/utils/misc/guc.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'src/backend/utils/misc/guc.c') diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index e7dd2bffe8f..38d577f87bb 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut . * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.531 2010/01/02 16:57:58 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.532 2010/01/07 04:53:35 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -4240,10 +4240,6 @@ parse_int(const char *value, int *result, int flags, const char **hintmsg) /* * Note: the multiple-switch coding technique here is a bit tedious, * but seems necessary to avoid intermediate-value overflows. - * - * If INT64_IS_BUSTED (ie, it's really int32) we will fail to detect - * overflow due to units conversion, but there are few enough such - * machines that it does not seem worth trying to be smarter. */ if (flags & GUC_UNIT_MEMORY) { @@ -6627,10 +6623,7 @@ _ShowOption(struct config_generic * record, bool use_units) { /* * Use int64 arithmetic to avoid overflows in units - * conversion. If INT64_IS_BUSTED we might overflow - * anyway and print bogus answers, but there are few - * enough such machines that it doesn't seem worth trying - * harder. + * conversion. */ int64 result = *conf->variable; const char *unit; -- cgit v1.2.3