From 75506195da81d75597a4025b72f8367e6c45f60d Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Sun, 4 Aug 2019 20:29:00 +0200 Subject: Revert "Add log_statement_sample_rate parameter" This reverts commit 88bdbd3f746049834ae3cc972e6e650586ec3c9d. As committed, statement sampling used the existing duration threshold (log_min_duration_statement) when decide which statements to sample. The issue is that even the longest statements are subject to sampling, and so may not end up logged. An improvement was proposed, introducing a second duration threshold, but it would not be backwards compatible. So we've decided to revert this feature - the separate threshold should be part of the feature itself. Discussion: https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com --- src/backend/utils/misc/postgresql.conf.sample | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'src/backend/utils/misc/postgresql.conf.sample') diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index cfad86c02a0..65a6da18b35 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -488,14 +488,10 @@ # fatal # panic (effectively off) -#log_min_duration_statement = -1 # logs statements and their durations - # according to log_statement_sample_rate. -1 is disabled, - # 0 logs all statements, > 0 logs only statements running - # at least this number of milliseconds. - -#log_statement_sample_rate = 1.0 # Fraction of logged statements exceeding - # log_min_duration_statement to be logged. - # 1.0 logs all such statements, 0.0 never logs. +#log_min_duration_statement = -1 # -1 is disabled, 0 logs all statements + # and their durations, > 0 logs only + # statements running at least this number + # of milliseconds #log_transaction_sample_rate = 0.0 # Fraction of transactions whose statements # are logged regardless of their duration. 1.0 logs all -- cgit v1.2.3