From f614a2b50842c5ced90cd5c5af802684028510a9 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 6 Aug 2007 01:38:24 +0000 Subject: Fix pg_restore to guard against unexpected EOF while reading an archive file. Per report and partial patch from Chad Wagner. --- src/bin/pg_dump/pg_backup_tar.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/bin/pg_dump/pg_backup_tar.c') diff --git a/src/bin/pg_dump/pg_backup_tar.c b/src/bin/pg_dump/pg_backup_tar.c index 60ed4f39e7a..b173cb9f426 100644 --- a/src/bin/pg_dump/pg_backup_tar.c +++ b/src/bin/pg_dump/pg_backup_tar.c @@ -16,7 +16,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_tar.c,v 1.56.2.1 2007/02/19 15:05:21 mha Exp $ + * $PostgreSQL: pgsql/src/bin/pg_dump/pg_backup_tar.c,v 1.56.2.2 2007/08/06 01:38:24 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -510,7 +510,7 @@ _tarReadRaw(ArchiveHandle *AH, void *buf, size_t len, TAR_MEMBER *th, FILE *fh) used = avail; /* Copy, and adjust buffer pos */ - memcpy(buf, AH->lookahead, used); + memcpy(buf, AH->lookahead + AH->lookaheadPos, used); AH->lookaheadPos += used; /* Adjust required length */ @@ -766,12 +766,13 @@ static int _ReadByte(ArchiveHandle *AH) { lclContext *ctx = (lclContext *) AH->formatData; - int res; - char c = '\0'; + size_t res; + unsigned char c; res = tarRead(&c, 1, ctx->FH); - if (res != EOF) - ctx->filePos += res; + if (res != 1) + die_horribly(AH, modulename, "unexpected end of file\n"); + ctx->filePos += 1; return c; } -- cgit v1.2.3