From 201a76183e2056c2217129e12d68c25ec9c559c8 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Thu, 29 Jul 2021 05:58:08 -0400 Subject: Unify PostgresNode's new() and get_new_node() methods There is only one constructor now for PostgresNode, with the idiomatic name 'new'. The method is not exported by the class, and must be called as "PostgresNode->new('name',[args])". All the TAP tests that use PostgresNode are modified accordingly. Third party scripts will need adjusting, which is a fairly mechanical process (I just used a sed script). --- src/bin/pg_rewind/t/RewindTest.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/bin/pg_rewind/t/RewindTest.pm') diff --git a/src/bin/pg_rewind/t/RewindTest.pm b/src/bin/pg_rewind/t/RewindTest.pm index 938c661afc2..367b99a438f 100644 --- a/src/bin/pg_rewind/t/RewindTest.pm +++ b/src/bin/pg_rewind/t/RewindTest.pm @@ -128,7 +128,7 @@ sub setup_cluster # Initialize primary, data checksums are mandatory $node_primary = - get_new_node('primary' . ($extra_name ? "_${extra_name}" : '')); + PostgresNode->new('primary' . ($extra_name ? "_${extra_name}" : '')); # Set up pg_hba.conf and pg_ident.conf for the role running # pg_rewind. This role is used for all the tests, and has @@ -176,7 +176,7 @@ sub create_standby my $extra_name = shift; $node_standby = - get_new_node('standby' . ($extra_name ? "_${extra_name}" : '')); + PostgresNode->new('standby' . ($extra_name ? "_${extra_name}" : '')); $node_primary->backup('my_backup'); $node_standby->init_from_backup($node_primary, 'my_backup'); my $connstr_primary = $node_primary->connstr(); -- cgit v1.2.3