From 4cb658af70027c3544fb843d77b2e84028762747 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Mon, 25 Nov 2019 09:40:53 +0900 Subject: Refactor reloption handling for index AMs in-core MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reworks the reloption parsing and build of a couple of index AMs by creating new structures for each index AM's options. This split was already done for BRIN, GIN and GiST (which actually has a fillfactor parameter), but not for hash, B-tree and SPGiST which relied on StdRdOptions due to an overlap with the default option set. This saves a couple of bytes for rd_options in each relcache entry with indexes making use of relation options, and brings more consistency between all index AMs. While on it, add a couple of AssertMacro() calls to make sure that utility macros to grab values of reloptions are used with the expected index AM. Author: Nikolay Shaplov Reviewed-by: Amit Langote, Michael Paquier, Álvaro Herrera, Dent John Discussion: https://postgr.es/m/4127670.gFlpRb6XCm@x200m --- src/include/access/spgist.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/include/access/spgist.h') diff --git a/src/include/access/spgist.h b/src/include/access/spgist.h index d787ab213dc..d5fd7bcc02b 100644 --- a/src/include/access/spgist.h +++ b/src/include/access/spgist.h @@ -19,10 +19,6 @@ #include "lib/stringinfo.h" -/* reloption parameters */ -#define SPGIST_MIN_FILLFACTOR 10 -#define SPGIST_DEFAULT_FILLFACTOR 80 - /* SPGiST opclass support function numbers */ #define SPGIST_CONFIG_PROC 1 #define SPGIST_CHOOSE_PROC 2 -- cgit v1.2.3